change family members widget requires save and re-invoke after each child

[Wes Groleau]

In SVN 9589, this is what I have to do to add children to a family:

Select change family members.
The widget appears with the bottom row of the table saying Add child / (blank) / Change
Click Change and select the child with the finder
The blank is replaced with the word undefined **
click Save
wait for the refresh, and then select change family members again.

At the **, according to the text above the table, it should put in either the name or the PID, and add a new row to the table. If you believe that text, and add another child, you actually replace the first one. But you can't tell that until you click Save because of the "undefined"

[ToyGuy (toyguy)]

Wes
Not sure this is really a bug when you consider how many sql actions are necessary (record updates) to make just one change.
It is much easier to use the LINK from the Relatives tab on the INDI record to add a child to an existing family. The Change Family tool is a great feature, but not practical to quickly add. Simply copy the FAM record XREF from the URL with a quick double-click, then use GEN SEARCH for finding the person you added (or add them and go to their record), and then use this quick link-up procedure. I've done it thousands of times. You can even use it to add Adoptions, Foster kids, or even to add a child to a correct family, then when it refreshes, click the wrong family record link and use the Change Family Members to delete the child from that family record.
-Stephen

[Wes Groleau (webmaster-unigen)]

I'm not sure I fully understand your explanation. But if you add five children, isn't there one FAMC update on each child and five on the family (if you do it once on each child). While here (if it would work as it's own text says, and as it did work at one time in the past), you still update each child once, and (maybe, if we're clever) _once_ on the family (adding all five CHIL links at once)?

In any case, there was a time when it worked the way the text above the table says.

And, IMHO, having the blank change to "undefined" after you select the child is a bug itself.

If the behavior is not to be changed, then the text should change to reflect the new behavior.

(Also, "the link to family" on the INDI's relatives tab is broken at the moment—I reported it earlier, but either the submit failed or the e-mail back to me failed.)

[Wes Groleau (webmaster-unigen)]

The submit did not fail, but I did not get the usual e-mail for
https://bugs.launchpad.net/webtrees/+bug/654334

[ToyGuy (toyguy)]

Wes
I've used the ADD A CHILD to an EXISTING FAMILY link about 20 times today, all w/o any issues and just did so again prior to writing this reply.

I have used the Change Family Members function since it was first added to PGV, and I have never seen it capable of adding more than one child at a time. I could be mistaken, but I've never seen that functionality.

Yes, the UNDEFINED is certainly a bug/error.
-Stephen

[fisharebest (fisharebest)]

The related by #1100139 has now been fixed.

The problem described here (can only add one child at a time) is actually working as designed - though I agree the design could be better.