Looping should try to prevent clicks
Bug #653896 reported by
Albert Santoni
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mixxx |
Fix Released
|
Medium
|
Owen Williams | ||
1.10 |
Won't Fix
|
Medium
|
Unassigned | ||
1.11 |
Fix Released
|
Medium
|
Owen Williams | ||
1.8 |
Won't Fix
|
Medium
|
Unassigned | ||
1.9 |
Won't Fix
|
Medium
|
Unassigned |
Bug Description
When looping, Mixxx should try to prevent clicking sounds caused by large, discontinuous jumps in the audio signal. The conventional way of doing this for mono streams is to adjust the loop start and end points to both coincide with zero crossings. This approach isn't so straightforward for stereo streams because zero crossings may not appear in both channels at the same time.
Nevertheless, I've written some code that attempts to find a compromise between the zero crossing positions in both the left and right channels, and I think it reduces clicking in most cases. Attached is the patch.
Probably a better way to do this is just to fade the audio over X samples.
Related branches
Changed in mixxx: | |
importance: | Wishlist → Medium |
status: | New → Confirmed |
Changed in mixxx: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
My patch in https:/ /bugs.launchpad .net/bugs/ 703585 solves this a different way, but crossfading between the out point and the in point over a period of one iBufferSize.