HR module on_change events bug

Bug #653690 reported by Parthiv Patel
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Undecided
vir (Open ERP)

Bug Description

Trunk Addons : Bzr revno : 4172

hr.py has many on_change events written some of them does not contain any conditions for NO DATA.

attached is the patch to resolve the issue.

Revision history for this message
Parthiv Patel (parthiv-patel-deactivatedaccount) wrote :
Revision history for this message
Parthiv Patel (parthiv-patel-deactivatedaccount) wrote :

attached is more cleaner patch for all hr related modules.

Changed in openobject-addons:
assignee: nobody → DHS(OpenERP) (dhs-openerp)
Changed in openobject-addons:
assignee: DHS(OpenERP) (dhs-openerp) → nobody
Revision history for this message
vir (Open ERP) (vir-tinyerp) wrote :

Hello

Thanks for suggesting improvements.

The changes which you suggested are already done in following branch.
https://code.launchpad.net/~openerp-commiter/openobject-addons/trunk_useability_addons branch
changes will be applicable when the branch will merge in trunk addons.

Regarding changes of hr_payroll module, currently we are improving hr_payroll module.

Thank you

Changed in openobject-addons:
status: New → Confirmed
milestone: none → 6.0-rc2
Changed in openobject-addons:
assignee: nobody → vir (Open ERP) (vir-tinyerp)
status: Confirmed → In Progress
Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote :

Fixed by revision 4453 <email address hidden>.
Thanks Parthiv and SKH.

Changed in openobject-addons:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.