project group does not show the unknown code hosting message

Bug #652156 reported by Curtis Hovey
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
j.c.sackett

Bug Description

https://code.edge.launchpad.net/tendra-project shows an empty listing. The page should clearly state Launchpad does not know where the code for any of the subjects are hosted. No listing should be presented.

Related branches

Curtis Hovey (sinzui)
summary: - project group does not show the unknown service message
+ project group does not show the unknown code hosting message
Curtis Hovey (sinzui)
Changed in launchpad-code:
milestone: 10.10 → 10.11
j.c.sackett (jcsackett)
Changed in launchpad-code:
assignee: nobody → j.c.sackett (jcsackett)
status: Triaged → In Progress
j.c.sackett (jcsackett)
Changed in launchpad-code:
status: In Progress → Fix Committed
tags: added: qa-ok
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit
tags: added: qa-needstesting
removed: qa-ok
Revision history for this message
Brad Crittenden (bac) wrote :

I have marked this bug 'qa-bad' because I'm getting timeouts on https://code.qastaging.launchpad.net/launchpad-project

The changes for this bug fix affected many of the files for the fix for bug 652149. As an experiment I had the revision of lib/lp/code/templates/project-branches.pt rolled back to see if that had any affect. It did not.

The timeouts I see occur when the page is viewed by a logged in user so the added overhead of the private bug query may be a factor.

Unfortunately the OOPS processor for qastaging is not currently working. One of the failures was OOPS-1760QS8 -- perhaps it will be visible when the OOPS processor works again.

tags: added: qa-bad
removed: qa-needstesting
Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 652156] Re: project group does not show the unknown code hosting message

The oops is on disk on devpad 2010-10-26/26376.QS8

This appears to be the issue:

01411-37439@SQL-launchpad-main-slave SELECT BugBranch.branch,
BugBranch.bug, BugBranch.datecreated, BugBranch.id,
BugBranch.registrant, BugBranch.revision_hint FROM Bug, BugBranch
WHERE BugBranch.branch in (376206, 27410, 27409, 62569, 294
656, 294682, 321347, 34756, 28862, 23341, 28047, 372856, 316063,
51207, 377921, 377385, 354082, 377384, 377190, 353197, 310594, 379461,
360876, 357739, 306414, 316689, 42346, 362057, 278968, 279709, 321554,
224835, 41768, 85149, 54826, 851
22, 36584, 48996, 353908, 42310, 362260, 363134, 365170, 365486,
325775, 326380, 326014, 327125, 351388, 361502, 317519, 355220,
275846, 81758, 275036, 274828, 294749, 295078, 300038, 308656, 273872,
309946, 160347, 326662, 380243, 256686,
 255739, 280855, 379600, 379616, 379376, 244083, 379153, 296620,
296600, 317404, 281693, 44192, 44911, 373688, 39499, 55597, 53082,
184246, 308688, 378619, 379099, 27153, 375970, 256487, 41011, 29835,
362963, 379357, 108619, 305882, 52671,
 379287, 371323, 379684) AND BugBranch.bug = Bug.id AND (Bug.private =
FALSE OR Bug.id in ( SELECT Bug.id FROM Bug, BugSubscription,
TeamParticipation WHERE Bug.id = BugSubscription.bug AND
TeamParticipation.person = 804595 AND BugSubscrip
tion.person = TeamParticipation.team)) AND (1=1)

Though 37 seconds is rather unbelievable - trying just now it took 2
seconds on the ro staging db.

Revision history for this message
j.c.sackett (jcsackett) wrote :

Some hunting shows this a timeout we already know about per bug 627945. We've seen it on Person:+branches and it's the same query as identified by Robert above.

I've updated the bug there and linked it to Robert's comment with the bad query.

I'm going to switch this back to qa-ok; Brad, I think you can resume qa-ing your branch.

tags: added: qa-ok
removed: qa-bad
Changed in launchpad-code:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.