Webservice related registry exception and error types should be collected in registry.errors
Bug #649836 reported by
j.c.sackett
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
j.c.sackett | ||
Bug Description
Custom exception and error types with the webservice_error directive are currently scattered across files in registry; they should be moved to an errors module within registry, which should be registered with webservice:register in a configure.zcml file.
Related branches
lp:~jcsackett/launchpad/registry-errors-649836
- Edwin Grubbs (community): Approve (code)
-
Diff: 1061 lines (+183/-178)28 files modifiedlib/canonical/launchpad/interfaces/__init__.py (+0/-1)
lib/canonical/launchpad/testing/pages.py (+2/-2)
lib/lp/code/model/branchlookup.py (+4/-2)
lib/lp/code/model/branchnamespace.py (+7/-9)
lib/lp/code/model/linkedbranch.py (+1/-1)
lib/lp/code/model/tests/test_branchlookup.py (+4/-2)
lib/lp/code/model/tests/test_branchnamespace.py (+4/-2)
lib/lp/code/model/tests/test_linkedbranch.py (+1/-1)
lib/lp/code/xmlrpc/branch.py (+4/-2)
lib/lp/registry/configure.zcml (+7/-0)
lib/lp/registry/errors.py (+97/-1)
lib/lp/registry/interfaces/distributionmirror.py (+6/-49)
lib/lp/registry/interfaces/distroseries.py (+1/-9)
lib/lp/registry/interfaces/person.py (+3/-21)
lib/lp/registry/interfaces/sourcepackagename.py (+2/-10)
lib/lp/registry/interfaces/structuralsubscription.py (+0/-16)
lib/lp/registry/interfaces/teammembership.py (+0/-12)
lib/lp/registry/model/distribution.py (+1/-2)
lib/lp/registry/model/distributionmirror.py (+10/-9)
lib/lp/registry/model/person.py (+2/-2)
lib/lp/registry/model/sourcepackagename.py (+3/-4)
lib/lp/registry/model/structuralsubscription.py (+4/-2)
lib/lp/registry/model/teammembership.py (+4/-2)
lib/lp/registry/tests/test_distribution.py (+1/-1)
lib/lp/registry/tests/test_distroseries.py (+4/-10)
lib/lp/registry/tests/test_person.py (+5/-3)
lib/lp/registry/tests/test_structuralsubscriptiontarget.py (+4/-2)
lib/lp/registry/tests/test_team_webservice.py (+2/-1)
| Changed in launchpad-registry: | |
| status: | New → In Progress |
| summary: |
- Registry exception and error types should be collected in - registry.errors + Webservice related registry exception and error types should be + collected in registry.errors |
| description: | updated |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #1 |
| Changed in launchpad-registry: | |
| milestone: | none → 10.10 |
| tags: | added: qa-needstesting |
| Changed in launchpad-registry: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad-registry: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r11673 <http://