Duplicate interfaces after upgrade disrupt ipdevpoll

[Morten Brekkevold]

getDeviceData had a propensity to create duplicate switch ports (and possibly router ports) when it changed its mind about which module a port belonged to.

Thes duplicate ports remain in the interface table after migrating to the 3.6 schema, and disrupts proper operation of ipdevpoll (which assumes duplicate interfaces can never happen).

The migration SQL needs to remove duplicates from the database, and a proper constraint on (netboxid, ifindex) needs to be added to the Interface table.

[Morten Brekkevold (mbrekkevold)]

fix here: http://metanav.uninett.no/hg/series/3.6.x/rev/1a8f59d3961a

[Morten Brekkevold (mbrekkevold)]

also this one: http://metanav.uninett.no/hg/series/3.6.x/rev/69859d45027b

[Morten Brekkevold (mbrekkevold)]

Incidentally, the new index on the interface table, that comes from the new constraint introduced in this fix, will immensely improve the speed of interface lookups. This has a huge impact on ipdevpoll, who would run really slowly when monitoring many devices.