[sale] incoterm field poorly implemented [direct sql / not translatable]

[Omar (Pexego)]

Hi,

Checking incoterm field in sales, I see that, it is a selection field with a get function, it should be a many2one field, directly to stock_incoterms, then in the view, if it wants, you write widget="selection".

Current implementation isn't good, because in the get function it uses a sql query. In addition, if you want work with this field it returns by default the code of incoterm (code isn't unique) instead of his Id.

I include my diff file. If my file is applied, you should delete the get function and incoterm line commented.

[Omar (Pexego) (omar7r)]

Another thing is that stock_incoterms name isn't translatable.

[Cristian Salamea (ovnicraft)]

Hello, also consider the values for incoterm computing, so here http://en.wikipedia.org/wiki/Incoterm#Summary_of_terms you can see 12 values depending from incoterm must be considered but can be as wishlist.

Regards,

[Cristian Salamea (ovnicraft)]

@Omar can you propose to merge your patch?

[Ashvin Rathod (OpenERP) (ara-tinyerp)]

Hello Omar (Pexego),

We have fixed the problem in lp:~openerp-dev/openobject-addons/trunk-dev-addons3-ara branch, It will be merged soon with Trunk addons.

Thank you,
ara