Static plugins are compiled with -fPIC in non-Win32 systems
Bug #648071 reported by
RedDwarf
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Stellarium |
Fix Released
|
Low
|
Unassigned |
Bug Description
Plugin code is full of
IF(WIN32)
SET_TARGET_
ELSE()
SET_TARGET_
ENDIF()
But since those *static* plugins end linked in the final single binary, its positions is known and -fPIC only adds an unneeded overhead.
Patch attached.
Changed in stellarium: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
The patch works fine. I didn't commit it, as there is additional code in the make CMakeLissts.txt file that deal with static vs. dynamic plugins, and that really should be cleaned up too.