Static plugins are compiled with -fPIC in non-Win32 systems

[RedDwarf]

Plugin code is full of

IF(WIN32)
 SET_TARGET_PROPERTIES(CompassMarks-static PROPERTIES COMPILE_FLAGS "-DQT_STATICPLUGIN")
ELSE()
 SET_TARGET_PROPERTIES(CompassMarks-static PROPERTIES COMPILE_FLAGS "-fPIC -DQT_STATICPLUGIN")
ENDIF()

But since those *static* plugins end linked in the final single binary, its positions is known and -fPIC only adds an unneeded overhead.

Patch attached.

[treaves (treaves)]

The patch works fine. I didn't commit it, as there is additional code in the make CMakeLissts.txt file that deal with static vs. dynamic plugins, and that really should be cleaned up too.

[Fabien Chéreau (xalioth)]

Thanks,
I suppressed all the -fPIC as you suggested in rev 4807
Fab