_KnitIndex.add_versions() doesn't dictionary compress new revisions

Bug #64789 reported by John A Meinel
2
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
Medium
John A Meinel

Bug Description

The add_versions() command is used during fetch activities. At this moment, all newly added revisions are not dictionary compressed.

This is especially noticable when creating a new push. Doing:

$ cd bzr.dev
$ bzr push ../new-test-branch

And then inspecting all .kndx files will show that none of them contain integer references for parent entries.

In discussing with Robert, it seems that just updating the cache as we go along, with rollback on error would be sufficient.

Related branches

Revision history for this message
John A Meinel (jameinel) wrote :

Not too difficult to fix, has some performance implications, and just general cleanliness issues.

Targeting for 0.12

Changed in bzr:
assignee: nobody → jameinel
importance: Undecided → Medium
status: Unconfirmed → Confirmed
Revision history for this message
John A Meinel (jameinel) wrote :

Missed 0.12, but should be higher priority for 0.13

Revision history for this message
John A Meinel (jameinel) wrote :

Associated branch has a fix for this.

Changed in bzr:
status: Confirmed → Fix Committed
Revision history for this message
Wouter van Heyst (larstiq) wrote :

merged in r2118

Changed in bzr:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.