"bzr check" does not handle our split up .bzr layout properly (Errors if there is no branch)

[Matthew Paul Thomas]

bzr check is not internally structured around checking repositories, branches and trees as separate items, its basically the original code from when there was only a Branch object, and as such it currently requires that a Branch be present. It needs to be refactored to:
 - check the repository directly.
 - scan for and find branches in the same repository under the path check was given and check they are valid and their history is in the repository.
 - scan for and find working trees likewise.

[Alexander Belchenko (bialix)]

I'm also have this error when runnign this command from shared repository without working trees.

'bzr check' intended to check consistency of branch history (as help says) and I assume it's means check consistency of repository but not working tree of branch.

So I think variant 3 is expected behaviour. I'm also think that 'bzr check' should check repository consistency when running from the root of shared repository.

It's should be not so hard to fix (just try to open branch and don't try to open working tree) so I set Medium importance for this bug.

[John A Meinel (jameinel)]

see also bug 111656

We should not fail if there is no WorkingTree, but we should check the working tree if it is available.

This should be easy since we have BzrDir.open_containing_tree_or_branch, which allows us to easily get a WT if it is available, else we just open the branch.

[Dan Watkins (oddbloke)]

This seems to be fixed in 0.92.0. ``check`` will now run against a branch in a no-trees repo. It does not run against a repository, but fails with a much more germane 'bzr: ERROR: Not a branch: "/home/daniel/devel/blah/.bzr/branch/".' I'll file a separate bug for running ``check`` against a repository.

[Robert Collins (lifeless)]

This is partially fixed as you can now run bzr check on a working tree, but the root problem, of not checking branches/repositories/trees cocneptually separately in the code is not fixed.

[Dan Watkins (oddbloke)]

Fixed in bzr.dev r3521.