included-text and attachments

[Uday Reddy]

blueman reports: (vm.info, 2010-07-30)

> If there is actually a picture in the Presentation buffer, what does
> > it do in the reply buffer? I have no idea.
> >
OK. I just tried it and I don't think it does what one would want it to.
I tried replying to a message with a picture in it. (Note I have
vm-mime-yank-attachment set to nil by default)

If I do it from a text-based emacs window where the picture is just
referenced as a button, then the inclusion is somewhat right in that at
least it looks the way it does in the original email. The included text
looks like:
 > Test with picture
 >
 > ----------------------------------------------------------------------
 > JPEG image [Press RETURN to save to a file]
 >
 > ----------------------------------------------------------------------
 > This is a test

However the "button" itself is no longer there (this is just text) and
therefore the "Press RETURN" is meaningless either in the reply buffer
or in the resulting sent email. Ideally, though it would be
better if the line looked something like
        DELETED JPEG image: file_name.jpg
signaling that there was originally an attachment that has been deleted
from the replied email.

If I have vm-mime-yank-attachment set to 't' then it works
perfectly. The button is preserved in the reply buffer and is sent
along as a functioning attachment in the actual sent email.

If I do it from a graphical frame-based emacs window where the picture
is displayed inline, then the inclusion is a lot messier. The included text
looks like:

 > Test with picture
 >
 > ----------------------------------------------------------------------
 > +-----+
 > |image|
 > |image|
 > |image|
 > |image|
 > |image|
 > |image|
 > |image|
 > |image|
 > |image|
 > |image|
 > |image|
 > |image|
 > |image|
 > |image|
 > |image|
 > |image|
 > |image|
 > |image|
 > |image|
 > |image|
 > |image|
 > |image|
 > |image|
 > +-----+
 >
 > ----------------------------------------------------------------------
 > This is a test

where I believe each |image| line corresponds to a line band of the
image. This is more clearly wrong.

Again I think the behavior should be as suggested above - single line
saying something like:
        DELETED JPEG image: file_name.jpg

EVEN WORSE, if I set vm-mime-yank-attachments, then the picture is
yanked and shows up graphically inline in the reply buffer BUT it is NOT
actually attached when the reply is sent - THIS IS CLEARLY A BUG I
THINK. The resulting replied/forwarded email just has multiple lines
saying |image|, identical to the case where vm-mime-yank-attachment is
nil. I.e. the attachment is never actually yanked.

I presume that other types of displayed or non-displayed MIME
attachments should be handled similarly.

[Uday Reddy (reddyuday)]

Revision 1013 includes text and message types and attachment buttons for the rest. Yet to do:

- Move code from vm-pine.el to vm-mime.el, renaming functions along the way
- Create "DELETED" indicators as requested above.

[Uday Reddy (reddyuday)]

Revision 1015 completes the fixes.