[5.0][sale] Cancelling an out picking sets the sale order as shipped
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Odoo Addons (MOVED TO GITHUB) |
Fix Released
|
High
|
Jay Vora (Serpent Consulting Services) |
Bug Description
Hi,
If I cancel an out picking, it always writes in sale order "shipped=True", because action_cancel() from stock.picking extended in sale module, calls to action_ship_end(), sale's function.
If picking was canceled. In action_ship_end(), it always writes shipped=True except that it finds in the sale, pickings in state different to 'done' or 'cancel', then when you cancel an out picking the sale order will be shipped and it isn't right.
I include a patch that changes this check, it searches for pickings in the sale with state different to 'done' or 'cancel' for calls to action_ship_end() if it only finds picking in done or cancel states it doesn't call to function. Reversing the current behavior.
Related branches
summary: |
- [5.0][sale] Cancelling an out picking always mark to shipped the sale + [5.0][sale] Cancelling an out picking sets the sale order as shipped |
Changed in openobject-addons: | |
status: | Confirmed → In Progress |
Changed in openobject-addons: | |
milestone: | 5.0.15 → none |
Hi,
I confirm the bug is present !! This is quite unfortunate, cause with the "Invoice on Order After Delivery" in SO, the invoiceis also generated if picking is canceled !!!
This is really unacceptable ! A cancel picking should never ever generate an invoice in that case !
The patch fix the problem, please include this in next release.
Regards,
Joël