Crash after scan or rotating

[bojo42]

Impact: simple-scan crashes when completing a single page being scanned or rotated
Resolution: Change in upstream project to fix rendering loop accessing pixels outside of image (patch in package branch and in comments below)
To reproduce:
1. Run simple-scan, e.g.
   $ simple-scan test
2. Scan one page
Expected result: Page is scanned and shows correct data
Observed result: simple-scan crashes when page complete or if page is rotated while scanning (note that since this bug is due to memory corruption it is not guaranteed to crash. A reliable method is to run simple-scan through valgrind as this will show invalid reads when rendering the page).

Patch has been tested and crash does not occur anymore, no errors reported by valgrind. Bug is well-defined (off by one error), no regression problems expected.

[bojo42 (bojo42)]

while valgrind debugging with valgrind i was able to do a 360 degrees rotation to the right.

[bojo42 (bojo42)]

this is still true in 2.32.0-0ubuntu1 backported to lucid. although i doubt it, but can someone please confirm that it isn't present in maverick.

[Markus Dresch (markus-dresch)]

i have the same problem with 2.32.0 in maverick.

[Robert Ancell (robert-ancell)]

Patch that fixes the problem

[Martin Pitt (pitti)]

Accepted simple-scan into maverick-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

[bojo42 (bojo42)]

works so far, but is it possible that rotating is now a bit slower? maybe it's just because i am now on a different machine. but great simple scan is usable again :)

[Martin Pitt (pitti)]

2.32.0-0ubuntu3 accepted into maverick-proposed, please test.

[Simon Hintermann (krazy-yvan)]

 Excellent!! But I updated with 2.32.0-0ubuntu2...

Thank you so much!

Simon

On 10/14/2010 09:36 AM, Martin Pitt wrote:
> 2.32.0-0ubuntu3 accepted into maverick-proposed, please test.
>

[bojo42 (bojo42)]

backported 2.32.0-0ubuntu3 still works fine. thumbs up for moving to -updates. have checked my speed issues and they are also in 2.32.0-0ubuntu1, so it's only related to my current machine.

[Launchpad Janitor (janitor)]

This bug was fixed in the package simple-scan - 2.32.0-0ubuntu3

---------------
simple-scan (2.32.0-0ubuntu3) maverick-proposed; urgency=low

  * debian/patches/03-blank_pdf.patch:
    - Fix error that caused the output PDF to be square

simple-scan (2.32.0-0ubuntu2) maverick-proposed; urgency=low

  * debian/patches/03_render_bug.patch:
    - Fix crash in page rendering (LP: #645901)
  * debian/patches/04_blank_pdf.patch
    - Fix invalid PDF files generate in locales that use ',' for a decimal point
      (LP: #644734)
 -- Robert Ancell <email address hidden> Wed, 13 Oct 2010 09:27:05 +1100

[Martin Pitt (pitti)]

Copied to natty as well.

[Robert Ancell (robert-ancell)]

Fixed in simple-scan 2.32.0.1