Crash on `bzr missing -v' against unbound branch of large svn repo

[Doug Lee]

This occurred in a local unbound bzr branch of a Subversion repo.
This occurs with `bzr missing -v' but not with just `bzr missing'.
Output of `bzr info -vvv' follows this script. This is under Bzr 2.2.0 Windows (stand-alone) on Vista. (I used Cygwin to make the script, but this is not a Cygwin bzr.)

Script started on Wed Sep 22 11:52:05 2010
% bzr missing -v
Using saved parent location: [http://... path to Subversion repo]
You have 5 extra revision(s):
 [successful list, with paths of changed files...]

You are missing 8 revision(s):
 [Two complete entries with paths, then where the third should be...]

bzr: ERROR: exceptions.AttributeError: 'DirectoryTreeDeltaBuildEditor' object has no attribute '_metadata_changed'

Traceback (most recent call last):
  File "bzrlib\commands.pyo", line 911, in exception_to_return_code
  File "bzrlib\commands.pyo", line 1111, in run_bzr
  File "bzrlib\commands.pyo", line 689, in run_argv_aliases
  File "bzrlib\commands.pyo", line 704, in run
  File "bzrlib\cleanup.pyo", line 135, in run_simple
  File "bzrlib\cleanup.pyo", line 165, in _do_with_cleanups
  File "bzrlib\commands.pyo", line 1126, in ignore_pipe
  File "bzrlib\builtins.pyo", line 4412, in run
  File "bzrlib\missing.pyo", line 38, in iter_log_revisions
  File "C:/tools/bazaar/plugins\svn\repository.py", line 583, in get_revision_delta
  File "C:/tools/bazaar/plugins\svn\repository.py", line 607, in get_delta_for_revision
  File "C:/tools/bazaar/plugins\svn\fetch.py", line 359, in change_prop
AttributeError: 'DirectoryTreeDeltaBuildEditor' object has no attribute '_metadata_changed'

bzr 2.2.0 on python 2.6.4 (Windows-Vista-6.0.6002-SP2)
arguments: ['C:\\tools\\bazaar\\bzr.exe', 'missing', '-v']
encoding: 'cp1252', fsenc: 'mbcs', lang: 'C.UTF-8'
plugins:
  bookmarks C:\tools\bazaar\plugins\bookmarks [unknown]
  bzrtools C:\tools\bazaar\plugins\bzrtools [2.2.0]
  colo C:\tools\bazaar\plugins\colo [0.1.0]
  explorer C:\tools\bazaar\plugins\explorer [1.1b1]
  fastimport C:\tools\bazaar\plugins\fastimport [0.9.0dev]
  launchpad C:\tools\bazaar\plugins\launchpad [2.2.0]
  loom C:\tools\bazaar\plugins\loom [2.2.1dev]
  netrc_credential_store C:\tools\bazaar\plugins\netrc_credential_store [2.2.0]
  news_merge C:\tools\bazaar\plugins\news_merge [2.2.0]
  pipeline C:\tools\bazaar\plugins\pipeline [unknown]
  qbzr C:\tools\bazaar\plugins\qbzr [0.19.0]
  rewrite C:\tools\bazaar\plugins\rewrite [0.6.0]
  svn C:\tools\bazaar\plugins\svn [1.0.3]
  upload C:\tools\bazaar\plugins\upload [1.0.0dev]
  xmloutput C:\tools\bazaar\plugins\xmloutput [0.8.6]

*** Bazaar has encountered an internal error. This probably indicates a
    bug in Bazaar. You can help us fix it by filing a bug report at
        https://bugs.launchpad.net/bzr/+filebug
    including this traceback and a description of the problem.
% exit

Script done on Wed Sep 22 11:52:23 2010

Output of `bzr info -vv':
Repository tree (format: 2a)
Location:
  shared repository: C:/cygwin/home/cvs/vad/adobe
  repository branch: .

Related branches:
    push branch: bzr+ssh://<email address hidden>:27222/var/bzr/adobe/dg/
  parent branch: http://opensource.adobe.com/svn/opensource/private/flex/sdk/branches/hero_private
  submit branch: http://opensource.adobe.com/svn/opensource/private/flex/sdk/branches/hero_private

Format:
       control: Meta directory format 1
  working tree: Working tree format 6
        branch: Branch format 7
    repository: Repository format 2a - rich roots, group compression and chk inventories

In the working tree:
     16742 unchanged
         0 modified
         0 added
         0 removed
         0 renamed
       193 unknown
         0 ignored
      1738 versioned subdirectories

Branch history:
      5549 revisions
        89 committers
      1014 days old
   first revision: Thu 2007-12-13 07:32:38 +0000
  latest revision: Wed 2010-09-22 11:42:23 -0400

Repository:
      5563 revisions

[Doug Lee (dgl-dlee)]

In case it helps, the local branch for this incident contains three merges at the top level and one second-level merge within one of the top-level ones (though I'm not seeing with -n0 any level-3 commits in that one).

[Jelmer Vernooij (jelmer)]

This is fixed, but we still need a proper test for it.

[Francis Devereux (frankoid)]

Thanks for the fix, I can confirm that it works for me (bug reproduces with "bzr missing -v" with bzr-svn 1.0.4, works fine with bzr+ssh://bazaar.launchpad.net/%2Bbranch/bzr-svn/ r3515 :-)

[Jelmer Vernooij (jelmer)]

On Tue, Feb 08, 2011 at 07:56:03PM -0000, Francis Devereux wrote:
> Thanks for the fix, I can confirm that it works for me (bug reproduces
> with "bzr missing -v" with bzr-svn 1.0.4, works fine with
> bzr+ssh://bazaar.launchpad.net/%2Bbranch/bzr-svn/ r3515 :-)
Thanks for verifying!

Cheers,

Jelmer