Crash Assert failed :_run->nbPushed<MAX_PUSHED

[ERE]

Binary package hint: avidemux

Crash

Assert failed :_run->nbPushed<MAX_PUSHED
 at line 278, file /build/buildd/avidemux-2.5.2/avidemux/ADM_inputs/ADM_mpegdemuxer/dmx_indexer_mpeg2.cppADM_backTrack
dmx_videoIndexerMpeg2::run()
dmx_indexer(char const*, char const*, unsigned int, unsigned char, unsigned int, MPEG_TRACK*)
ADM_Composer::tryIndexing(char const*, char const*)
ADM_Composer::addFile(char const*, unsigned char, fileType)
avidemux2_gtk() [0x45e7e7]
automation()
avidemux2_gtk() [0x57b6e8]

g_main_context_dispatch

g_main_loop_run
gtk_main
UI_RunApp()
main
__libc_start_main
avidemux2_gtk() [0x45a899]

ProblemType: Bug
DistroRelease: Ubuntu 10.04
Package: avidemux 1:2.5.2-0ubuntu3
ProcVersionSignature: Ubuntu 2.6.32-25.44-generic 2.6.32.21+drm33.7
Uname: Linux 2.6.32-25-generic x86_64
Architecture: amd64
Date: Tue Sep 21 13:42:25 2010
ExecutablePath: /usr/bin/avidemux2_gtk
InstallationMedia: Ubuntu 10.04 LTS "Lucid Lynx" - Release amd64 (20100429)
ProcEnviron:
 LANG=fr_FR.utf8
 SHELL=/bin/bash
SourcePackage: avidemux

[ERE (karfter)]

Is this reproducible on Maverick?
YES
Crash

Assert failed :_run->nbPushed<MAX_PUSHED
 at line 278, file /build/buildd/avidemux-2.5.3/avidemux/ADM_inputs/ADM_mpegdemuxer/dmx_indexer_mpeg2.cppADM_backTrack
dmx_videoIndexerMpeg2::run()
dmx_indexer(char const*, char const*, unsigned int, unsigned char, unsigned int, MPEG_TRACK*)
ADM_Composer::tryIndexing(char const*, char const*)
ADM_Composer::addFile(char const*, unsigned char, fileType)
avidemux2_gtk() [0x44deb7]
automation()
avidemux2_gtk() [0x53b528]

g_main_context_dispatch

g_main_loop_run
gtk_main
UI_RunApp()
main
__libc_start_main
avidemux2_gtk() [0x449ee9]

[ERE (karfter)]

Full log for Maverick

[Alessio Treglia (quadrispro)]

Is this reproducible with the latest upstream release available on Natty?

[Launchpad Janitor (janitor)]

[Expired for avidemux (Ubuntu) because there has been no activity for 60 days.]

[mykola.kutsyy (n-p-kutsyy)]

$ uname -a
Linux nick-desktop 2.6.32-27-generic #49-Ubuntu SMP Wed Dec 1 23:52:12 UTC 2010 i686 GNU/Linux

Version installed of avidemux: 1:2.5.2-1~getdeb1

---------------

I can reproduce this defect as following:
1. File > Open...
2. Select my MOV file
3. Dialog: This looks like mpeg
 Do you want to index it?
> Click Yes
4. At the end of indexing got the following Error message

Error message:
Crash

Assert failed :_run->nbPushed<MAX_PUSHED
 at line 278, file /build/build-avidemux_2.5.2-1~getdeb1-amd64-W4yUAN/avidemux-2.5.2-1~getdeb1/avidemux/ADM_inputs/ADM_mpegdemuxer/dmx_indexer_mpeg2.cppADM_backTrack
dmx_videoIndexerMpeg2::run()
dmx_indexer(char const*, char const*, unsigned int, unsigned char, unsigned int, MPEG_TRACK*)
ADM_Composer::tryIndexing(char const*, char const*)
ADM_Composer::addFile(char const*, unsigned char, fileType)
avidemux2_gtk() [0x8099f3f]
FileSel_ReadWrite(void (*)(char const*), int, char const*, char const*)
avidemux2_gtk() [0x81addc2]
GUI_FileSelRead(char const*, void (*)(char const*))
HandleAction(Action)
guiCallback(_GtkMenuItem*, void*)
g_cclosure_marshal_VOID__VOID
g_closure_invoke

g_signal_emit_valist
g_signal_emit_by_name

g_cclosure_marshal_VOID__VOID
g_closure_invoke

[kapetr (kapetr)]

On Maverick too.

Why was this bug report expired ?
The bug is there, it is no our problem, that nobody cares.

Sorry - I do not understand Bugs life :-(

[-Ted Merrill (78luphr0rnk2nuqimstywepozxn9kl19tqh0tx66b5dki1xxsh5-phnohh065-a811i2i3ytqlsztthjth0svbccw8inm65tmkqp9sarr553jq53i)]

I think i found the problem... at least i'm able to get avidemux to work instead of getting these silly assertions!

The problem is in the avidemux source code where they impose arbitrary limits on the number of P-frames that can follow an I-frame ... restrictions that are exceeded by mencoder...

I downloaded source code for avidemux 2.5.5 (Ubuntu 11.10 uses 2.5.4 but i think the problem is the same).
In the directory avidemux_2.5.5/avidemux/ADM_inputs i fixed the following:
ADM_mpegdemuxer/dmx_indexer_internal.h :
changed
 #define MAX_PUSHED 200
to
#define MAX_PUSHED 2000
... and in ADM_mpegdemuxer/dmx_video.cpp
changed
#define MAX_LINE 4096
to
#define MAX_LINE 40960

Of course, there is no guarantee that these sizes are large enough either (although they worked for my case)...
clearly the program algorithm should be rethought to work with arbitrary sizes...
there could be other similar problems in the code as well...

In order to compile beneath ubuntu 11.0 i ALSO had to make the following changes:
in plugins/ADM_videoEncoder/ADM_vidEnc_x264/encoder.cpp
i commented out the line that says:
printf("[x264] i_open_gop = %d\n", x264Param->i_open_gop);
... and in plugins/ADM_videoEncoder/ADM_vidEnc_x264/x264Options.cpp
i modified x264Options::getOpenGopMode(void) to simply return 0 and
modified x264Options::setOpenGopMode(unsigned int openGopMode)
to do nothing (to avoid errors related to undefined field i_open_gop).
... i have no idea if this might cause a problem with someone using x264 stuff...

With these changes i have been able to use my locally compiled avidemux_qt4 under ubuntu 11.10 to edit dvd-compatible mpeg output generated by mencoder...

-Ted Merrill

[mean (fixounet)]

Agreed the arbitrary limitation on gop size is a bug, especially since it leads to a crash,
but a gop size > 200 is definitively not DVD compliant, even if most DVD player will accept it.

For DVD gop size is around 20 (the value changes between PAL/NTSC and FILM)