patron password not reset to phone

[James Fournie]

When the patron.password.use_phone is set, new patrons are created with their password set to the last 4 digits of their phone number, HOWEVER, when a patron's password is reset, it does not work properly. Although the little underlined summary shows the proper 4 digits, the password box displays 9-ish digits, and is not the last 4 digits of the password.

The attached patch was created by Steve Callender and is confirmed working on 1.6.0

This patch will not work on 2.0 as that has a new user editor, but it would presumably be worthwhile to verify this functionality works in that editor as well.

~J

[Mike Rylander (mrylander)]

James and Steve, thanks!

Patch applied to all open branches, including trunk/2.0, as they still contain the old user editor.

[Bill Ott (bott)]

Doesn't this break the pre-population of the new password for newly created accounts?

Shouldn't the if(!pw) be closed before the assignment of form values?

[Bill Ott (bott)]

We've also discovered that a phone number change indiscriminately updates the password. Maybe due to my change noted above? A quick check in ue_config.js for an isnew() prevents that.

With limited testing, I've attached a diff against rel_1_6_0.

[Jason Etheridge (phasefx)]

Steve and I were poking at this recently too (unaware of the ticket) and I committed what amounts to half of Bill's patch already, and was waiting on the isnew() check before backporting. :-)

http://svn.open-ils.org/trac/ILS/changeset/18355

I'll get the rest of it in.

Thanks!

[Jason Etheridge (phasefx)]

http://svn.open-ils.org/trac/ILS/changeset/18400
http://svn.open-ils.org/trac/ILS/changeset/18401