Error when computing sales order

[stijnbe]

When I try to compute a new sales order, save the order or deposit a sales order I get this error:

Environment Information :
System : Linux-2.6.32-24-generic-x86_64-with-Ubuntu-10.04-lucid
OS Name : posix
Distributor ID: Ubuntu
Description: Ubuntu 10.04.1 LTS
Release: 10.04
Codename: lucid
Operating System Release : 2.6.32-24-generic
Operating System Version : #43-Ubuntu SMP Thu Sep 16 14:58:24 UTC 2010
Operating System Architecture : 64bit
Operating System Locale : en_US.UTF8
Python Version : 2.6.5
OpenERP-Client Version : 6.0dev
Last revision No. & ID :1564 <email address hidden>
Traceback (most recent call last):
  File "/home/stijnbe/Testing/openerp/openobject-server/bin/netsvc.py", line 439, in dispatch
    result = ExportService.getService(service_name).dispatch(method, auth, params)
  File "/home/stijnbe/Testing/openerp/openobject-server/bin/service/web_services.py", line 586, in dispatch
    res = fn(db, uid, *params)
  File "/home/stijnbe/Testing/openerp/openobject-server/bin/osv/osv.py", line 57, in wrapper
    return f(self, dbname, *args, **kwargs)
  File "/home/stijnbe/Testing/openerp/openobject-server/bin/osv/osv.py", line 140, in execute
    res = pool.execute_cr(cr, uid, obj, method, *args, **kw)
  File "/home/stijnbe/Testing/openerp/openobject-server/bin/osv/osv.py", line 130, in execute_cr
    return getattr(object, method)(cr, uid, *args, **kw)
  File "/home/stijnbe/Testing/openerp/openobject-addons/sale/sale.py", line 391, in create
    return super(sale_order, self).create(cr, uid, vals, context=context)
  File "/home/stijnbe/Testing/openerp/openobject-server/bin/osv/orm.py", line 3774, in create
    wf_service.trg_create(user, self._name, id_new, cr)
  File "/home/stijnbe/Testing/openerp/openobject-server/bin/workflow/wkf_service.py", line 72, in trg_create
    instance.create(cr, ident, wkf_id)
  File "/home/stijnbe/Testing/openerp/openobject-server/bin/workflow/instance.py", line 30, in create
    cr.execute('insert into wkf_instance (res_type,res_id,uid,wkf_id) values (%s,%s,%s,%s) RETURNING id', (res_type,res_id,uid,wkf_id))
  File "/home/stijnbe/Testing/openerp/openobject-server/bin/sql_db.py", line 75, in wrapper
    return f(self, *args, **kwargs)
  File "/home/stijnbe/Testing/openerp/openobject-server/bin/sql_db.py", line 122, in execute
    res = self._obj.execute(query, params)
ProgrammingError: syntax error at or near "RETURNING"
LINE 1: ...e,res_id,uid,wkf_id) values (E'sale.order',4,1,5) RETURNING ...
                                                             ^
Version is latest trunk

[Jay Vora (Serpent Consulting Services) (jayvora)]

Hello Stijn,

I don't confirm the error as I could not meet it at my end.
But as a probable workaround,I guess it comes due to locale settings.

May be, the attached patch will solve it at your end.
Let me know what are the steps you perform to get the error and notify us about the behavior after applying the patch.

Thanks.

[stijnbe (stijnbe)]

I applied the patch and now I get a little different error (E is gone in query):

Environment Information :
System : Linux-2.6.32-24-generic-x86_64-with-Ubuntu-10.04-lucid
OS Name : posix
Distributor ID: Ubuntu
Description: Ubuntu 10.04.1 LTS
Release: 10.04
Codename: lucid
Operating System Release : 2.6.32-24-generic
Operating System Version : #43-Ubuntu SMP Thu Sep 16 14:58:24 UTC 2010
Operating System Architecture : 64bit
Operating System Locale : en_US.UTF8
Python Version : 2.6.5
OpenERP-Client Version : 6.0dev
Last revision No. & ID :1564 <email address hidden>
Traceback (most recent call last):
  File "/home/stijnbe/Testing/openerp/openobject-server/bin/netsvc.py", line 439, in dispatch
    result = ExportService.getService(service_name).dispatch(method, auth, params)
  File "/home/stijnbe/Testing/openerp/openobject-server/bin/service/web_services.py", line 586, in dispatch
    res = fn(db, uid, *params)
  File "/home/stijnbe/Testing/openerp/openobject-server/bin/osv/osv.py", line 57, in wrapper
    return f(self, dbname, *args, **kwargs)
  File "/home/stijnbe/Testing/openerp/openobject-server/bin/osv/osv.py", line 140, in execute
    res = pool.execute_cr(cr, uid, obj, method, *args, **kw)
  File "/home/stijnbe/Testing/openerp/openobject-server/bin/osv/osv.py", line 130, in execute_cr
    return getattr(object, method)(cr, uid, *args, **kw)
  File "/home/stijnbe/Testing/openerp/openobject-addons/sale/sale.py", line 391, in create
    return super(sale_order, self).create(cr, uid, vals, context=context)
  File "/home/stijnbe/Testing/openerp/openobject-server/bin/osv/orm.py", line 3774, in create
    wf_service.trg_create(user, self._name, id_new, cr)
  File "/home/stijnbe/Testing/openerp/openobject-server/bin/workflow/wkf_service.py", line 72, in trg_create
    instance.create(cr, ident, wkf_id)
  File "/home/stijnbe/Testing/openerp/openobject-server/bin/workflow/instance.py", line 30, in create
    cr.execute("insert into wkf_instance (res_type,res_id,uid,wkf_id) values ('%s',%s,%s,%s) RETURNING id" % (res_type,res_id,uid,wkf_id))
  File "/home/stijnbe/Testing/openerp/openobject-server/bin/sql_db.py", line 75, in wrapper
    return f(self, *args, **kwargs)
  File "/home/stijnbe/Testing/openerp/openobject-server/bin/sql_db.py", line 122, in execute
    res = self._obj.execute(query, params)
ProgrammingError: syntax error at or near "RETURNING"
LINE 1: ...pe,res_id,uid,wkf_id) values ('sale.order',9,1,5) RETURNING ...
                                                             ^

[stijnbe (stijnbe)]

Looks like I have an old postgresql (8.1.*) version causing this problem. I installed postgresql from the centos repositories. RETURNING only exists since 8.2 .
Thanks for your help I will now try to upgrade my postgres.

[stijnbe (stijnbe)]

Using your patch and upgrading my postgresql to 8.4 solved the problem.

thanks

[Jay Vora (Serpent Consulting Services) (jayvora)]

Closing the bug as it does not occur with latest OpenERP and latest psql too.
Thanks Stijn.

[stijnbe (stijnbe)]

Upgrading pgsql alone did not solve the problem I needed your patch. What could be wrong there?

Thanks

[Jay Vora (Serpent Consulting Services) (jayvora)]

If it is so, I need to check with other locale too.
I will try it asap.
Thanks.

[Dhruti Shastri(OpenERP) (dhs-openerp)]

Hello Stijn,

I tried with (Operating System) Locale : en_US.UTF8, but no error found at my end.(PostgreSQL 8.4.4)

Are you sure that you really needed to apply the patch?

Let me inform if you are getting still error without applying patch.

Thanks.

[stijnbe (stijnbe)]

I still get this error without patch:
db.cursor:Programming error: syntax error at or near "sale"
LINE 1: ..._instance (res_type,res_id,uid,wkf_id) values ('E'sale.order...
                                                             ^
, in query insert into wkf_instance (res_type,res_id,uid,wkf_id) values ('%s',%s,%s,%s) RETURNING id

[Dhruti Shastri(OpenERP) (dhs-openerp)]

Hello Stijn,

This is getting interesting.

If you have updated your psql version and you still get the same error, it looks like an issue of query generation(I mean using % in query sounds a better approach).

I will investigate more and will come back on this asap.

Thanks.

[stijnbe (stijnbe)]

Owkey it looks like I didn't fully revert your patch. I forgot to remove the quotes around %s.
Sorry for seeing this so late. And thanks for your help.

[Jay Vora (Serpent Consulting Services) (jayvora)]

Let me know if I can close this.
Thanks.

[stijnbe (stijnbe)]

You can close this issue sorry for wasting your time. But in the meanwhile I learned something more about openerp and python.
Thanks

[Jay Vora (Serpent Consulting Services) (jayvora)]

Thanks for the response.