FoW visibility of other players

[Stefan Kriwanek (Divan)]

If one (I) has shared/team view with another player (II) then a third player (III), that is visible in player II's fog of war (but not fully visible), is not displayed in player I's FoW - but it should be, as other FoW-objects of II are visible for I.

[OLiver (postfach-von-oli)]

Well there shouldn't be any fow objects visible for the player who didn't discover them. But I've implemented this feature now, maybe you could test it if you like..

[Stefan Kriwanek (Divan) (dev-stefankriwanek)]

Thanks you! I looked into your code a bit, seems I didn't realize the full complexity of it until then ;)

However, there's still one issue: Teams need not be static. In my opinion, both players should then remember the newest FoW even after their contract has ended and regardless of who once discovered it.

And, well, the shared FoW did not work for me (rev 6773), see attached savegame.

Also, the game crashes if the pink player scrolls it's view to the north of the blue one, I guess it is related, as only the game of the pink player crashes.

[Stefan Kriwanek (Divan) (dev-stefankriwanek)]

Great, it works!

But still one thing: An enemy visible so some player in FoW is not displayed in his friend's map (the small map).

[Spike (fvv1)]

Is this still a bug?
If yes, please re-report here: https://github.com/Return-To-The-Roots/s25client/issues