Does not correctly identify Sandisk Sansa e270

Bug #64300 reported by Chris Jones
2
Affects Status Importance Assigned to Milestone
HAL
Fix Released
Medium
hal (Ubuntu)
Fix Released
Low
Martin Pitt

Bug Description

hald is not setting the portable_audio_player property on the Sandisk Sansa e2xx series of mp3 players.
I have reported this upstream and attached an fdi stub that I think will work, but I do not have USB ids for the other models in the range.

Revision history for this message
In , Chris Jones (cmsj) wrote :

I think this will work. At the very least it has the right vendor/product IDs:

Bus 005 Device 013: ID 0781:7421 SanDisk Corp.

and the device supports mp3 and wma

  <!-- Sandisk Corp. Sansa e270 (maybe others as well) -->
      <match key="@storage.physical_device:usb.vendor_id" int="0x0781">
        <match key="@storage.physical_device:usb.product_id" int="0x7421">
           <append key="info.capabilities"
type="strlist">portable_audio_player</append>
           <merge key="info.category" type="string">portable_audio_player</merge>
           <merge key="portable_audio_player.type" type="string">generic</merge>
           <merge key="portable_audio_player.access_method"
type="string">storage</merge>
           <merge key="portable_audio_player.storage_device"
type="copy_property">info.udi</merge>
           <append key="portable_audio_player.output_formats"
type="strlist">audio/mpeg</append>
           <append key="portable_audio_player.output_formats"
type="strlist">audio/x-ms-wma</append>
           <append key="portable_audio_player.input_formats"
type="strlist">audio/mpeg</append>
           <append key="portable_audio_player.input_formats"
type="strlist">audio/x-ms-wma</append>
           </match>
      </match>

Revision history for this message
Chris Jones (cmsj) wrote :

hald is not setting the portable_audio_player property on the Sandisk Sansa e2xx series of mp3 players.
I have reported this upstream and attached an fdi stub that I think will work, but I do not have USB ids for the other models in the range.

Revision history for this message
Martin Pitt (pitti) wrote :

Easy and safe fix, will apply for edgy.

Changed in hal:
assignee: nobody → pitti
importance: Undecided → Low
status: Unconfirmed → In Progress
Changed in hal:
status: Unknown → Confirmed
Martin Pitt (pitti)
Changed in hal:
status: In Progress → Fix Committed
Revision history for this message
Martin Pitt (pitti) wrote :

 hal (0.5.7.1-0ubuntu15) edgy; urgency=low
 .
   * Add debian/patches/00upstream-05-fix-stale_nfs_handle_block.patch:
     - Do not stat NFS mounts when preparing for suspend to fix hang.
     - Patch taken from upstream git.
     - Closes: LP#64266
   * Add debian/patches/20_laptop-panel-fixes.patch: ThinkPad T60 controls
     screen brightness in hardware, so set the appropriate flag in
     10-laptop-panel-mgmt-policy.fdi. Closes: LP#61184
   * Add debian/patches/21_smartcard_drivetype.patch: Recognize 'Storage-SDC'
     as smart card drive type. Closes: LP#61834
   * Add debian/patches/22-prefer-pmi-over-powersave.patch: Prefer pmi over
     powersave in the suspend/hibernate scripts. Closes: LP#61920
   * debian/patches/17-mp3-player-fdi.patch: Add information about Sandisk
     Corp. Sansa e270. Closes: LP#64300
   * debian/patches/02_ignored_volumes.patch: Ignore Apple bootstrap partitions
     on removable devices, too. Closes: LP#61767
   * Add debian/patches/00upstream-06-stat-dev-not-mountpoint.patch:
     - hald/linux/blockdev.c, blockdev_refresh_mount_state(): Stat the special
       device file, not the mount point's underlying device. This makes hal
       correctly recognize fuse mounts.
     - Patch ported from upstream GIT, thanks to Florent Mertens!
       http://gitweb.freedesktop.org/?p=hal.git;a=commit;h=2ea340399bf8cf3d2bb6bd1b5c4ecbc2042e93d4
     - Closes: LP#35354

Changed in hal:
status: Fix Committed → Fix Released
Revision history for this message
In , Anonymous-dodgeit (anonymous-dodgeit) wrote :

I have an e250, and can confirm identical product and vendor strings. Seems
it's the same throughout the entire line... only difference is how much flash
storage there is.

Revision history for this message
In , Danny Kukawka (danny-kukawka) wrote :

Device is in now (hal-info package)

Changed in hal:
status: Confirmed → Fix Released
Changed in hal:
importance: Unknown → Medium
Changed in hal:
importance: Medium → Unknown
Changed in hal:
importance: Unknown → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.