The tutorial may crash when building roads preparing for warfare scenario

[Hans Joachim Desserud]

When preparing for the warfare part of the tutorial, the player is given some buildings (warehouse plus a fort and some other military buildings). After these buildings have been placed, roads are built between them. When the long road going south of the fort towards the eastern sentry had been built, this road curved and looked like the top of an S. So, when the script tried to continue this road and connect it too the flag just below the warehouse the only place the road could go was straight through the previous road. At this point the game crashed.
Unfortunately I did not have time to take a screenshot, nor do I have the log from the command line. I have attached a simple sketch, which I hope may make more sense than my explanation.
I assume the reason it crashed was trees taking up too much space, forcing the road to twist, and making it impossible to connect it the the road from the warehouse. While this is just a guess, it may be an idea to make sure the areas around the buildings are cleared, in order to build the roads.

Version: Widelands bzr rev 5518 on Ubuntu 10.04.

[Hans Joachim Desserud (hjd)]

See the attached sketch. The game crashed when it tried to build a road from flag A to flag B.

[SirVer (sirver)]

the problem is that trees are spreading into the location were the streets should be build. I'll investigate that.

[SirVer (sirver)]

Fixed in r5519. Thanks for reporting!

[Hans Joachim Desserud (hjd)]

Reopening since it is still possible to crash the tutorial when the roads are built. While it seems the area is cleared for the first roads this does not seem to happen for the long road going below the fort.

While it can happen in normal games, the easiest way to reproduce this is to speed up the game for a while to let the trees spread out and cover the area.

The game will crash with the following error:
PANIC: unprotected error in call to Lua API ([string "map:init"]:131: attempt to index local 'panel' (a nil value))

Widelands bzr rev 5541.

[Hans Joachim Desserud (hjd)]

The attached savegame demonstrates the problem.
Instructions:
1. Load the game.
2. Connect the sentry to the HQ in order for it to get built.
3. Click through a few dialogs.

[SirVer (sirver)]

The tutorial did not crash for me with the attached savegame in bzr5542. Does it crash for you before the trainingsarea in the east is build or after this?

[Hans Joachim Desserud (hjd)]

"Does it crash for you before the trainingsarea in the east is build or after this?" When building the roads to connect the buildings.

I've written down a more in-depth description of what happens. Hope this helps:
I load the savegame.
I connect the sentry to the HQ, in order to build it.
When the sentry is finished this triggers the part with geologist/mines.
I click through the dialogs with the geologist.
When the geologist is finished marking resources; the tutorial shifts to soldiers and warfare and the view moves northeast.
The buildings are created. (Everything works fine)
The trees between the trainingcamp and the warehouse disappears and a road is built, connecting the two buildings. (Also fine)
A road is built from the western sentry to the road between the trainingcamp and warehouse. (Still fine)
The game tries to build a road from the western sentry, going below the fort to the eastern sentry. At this point the trees blocking is not removed and the game crashes.

[SirVer (sirver)]

I could reproduce this now and I made another attempt at this in r5545. Please test.

[SirVer (sirver)]

I forgot to add: the savegame will still show the wrong behaviour, you have to start a new tutorial game with the current build if you want to test the fix.

[Hans Joachim Desserud (hjd)]

Tested a few times and the problem seem to be properly fixed now. Thanks :)

[SirVer (sirver)]

Released in build16-rc1