Little improvements to shoutcast

[Guy Martin]

The attached patch improves the shoutcast engine in two ways :

 - remove useless dialog when it's able to connect and disconnect correctly
There are already dialog if it fails with detailed error message, no need to get one if it works.

- don't add a dash in the song metadata if the artist is empty
This occurs when there are no metadata in the mp3 or file you are playing. The title will contain the filename tho.

[RJ Skerry-Ryan (rryan)]

I do remember getting 2 popups when I couldn't connect once. But I like the connect/disconnect popups because currently we have no way of providing UI feedback that you are 'On Air'.

I think EngineShoutcast needs a ControlObject like shoutcast_connected or something that is 0 or 1. That way skins could provide a red or green light depending on whether the person is connected.

[RJ Skerry-Ryan (rryan)]

Tobias, could you take a look and comment?

[Guy Martin (gmsoft)]

Actually there is already a way to find out from the UI if you are connected or not. If you are the menu item in Options -> Enable live broadcasting will be checked.

[RAFFI TEA (raffitea)]

I'll take a look at the code shortly. I've to hook up with some other developer because I need guidance on how to implement a gui widget object.

[RAFFI TEA (raffitea)]

I've addressed some issues in trunk r2534:
* don't add a dash in the song metadata if the artist is empty

The redundant message boxes haven't been removed: I agree on RJ Ryan and argue that the checkbox within the preferences is a hidden place. Usually, people don't have preferences open during transmission. We need a kind of GUI widget on the skin for that.

BTW: r2534 doesn't address the 2 popups when I couldn't connect once

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/5525