GTG

config not completely saved in browser.py

Bug #640531 reported by Lionel Dricot
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
GTG
Fix Released
High
Unassigned

Bug Description

handling of config in browser.py is a complete mess.

Currently, some value are not saved, other are not restored and the whole config is overwritten when closing the browser !!!

A refactorization is needed in order to make this work :

- collapsed state should be remembered for both tasks and tags
- size of the closed task pane should be remembered.
- the whole config['browser'] should become config (the browser should receive as argument config['browser'])

Changed in gtg:
importance: Undecided → High
milestone: none → 0.3
status: New → Confirmed
Revision history for this message
Luca Invernizzi (invernizzi) wrote :

I completely agree that we'll need to refactor the browser.
I think config should be handled by the CoreConfig object. That doesn't need to be passed as argument, everything can have access to it just by creating an instance of that (it's a borg, every instance is really the same one).
Also, private_config has to go (I don't even know if it's still there.

Changed in gtg:
assignee: nobody → Lionel Dricot (ploum)
Revision history for this message
Lionel Dricot (ploum-deactivatedaccount) wrote :

Fixed in rev. 924 (mostly, the collapsed state is not restored but this is a liblarch-gtk bug, not a config one)

Changed in gtg:
status: Confirmed → Fix Committed
Changed in gtg:
milestone: 0.3 → 0.2.9
Izidor Matušov (izidor)
Changed in gtg:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.