Reassign review request page needs a cancel option
Bug #640193 reported by
Ian Booth
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Ian Booth | ||
Bug Description
When reassigning a reviewer for a merge proposal, there should be a Cancel option available if you change your mind about doing the reassignment. All/most other pages have a Cancel option, so at least for consistency, so should this page.
URL of affected page is something along the lines of:
https:/
To reproduce, click on the yellow "Reassign Reviewer" dot next to a reviewer on the Merge Proposal page for a branch.
Related branches
lp:~wallyworld/launchpad/reassign-reviewer-cancel-option
- Tim Penhey (community): Approve
- Steve Kowalik (community): Approve (code*)
- Launchpad code reviewers: Pending (code) requested
-
Diff: 99 lines (+30/-13)2 files modifiedlib/lp/code/browser/codereviewvote.py (+7/-2)
lib/lp/code/browser/tests/test_codereviewvote.py (+23/-11)
| affects: | launchpad → launchpad-code |
| tags: | added: trivial |
| Changed in launchpad-code: | |
| status: | New → Triaged |
| Changed in launchpad-code: | |
| assignee: | nobody → Ian Booth (wallyworld) |
| Changed in launchpad-code: | |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #1 |
| Changed in launchpad-code: | |
| milestone: | none → 10.10 |
| tags: | added: qa-needstesting |
| Changed in launchpad-code: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad-code: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r11649 <http://