Cuneiform for Linux

i386 assembly

Bug #640038 reported by Jakub Wilk
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cuneiform for Linux
Fix Released
Undecided
Unassigned

Bug Description

In Kern/rstr/src/perc.c, there is some i386 assembly code used to swap byte order. This is ugly and unportable.
In Debian this issue was fixed by applying the attached patch; however it is not very portable either, as it requires a relatively recent version of GNU libc.
Perhaps the most portable way to fix it is to use the htonl() function: http://opengroup.org/onlinepubs/007908775/xns/htonl.html

Revision history for this message
Jakub Wilk (jwilk) wrote :
Revision history for this message
Jussi Pakkanen (jpakkane) wrote :

I can't apply this patch as is, because it would break OSX and probably also Windows. I'll try to look into this soon.

Revision history for this message
Jussi Pakkanen (jpakkane) wrote :

Trunk now has an explicit check for endian.h. Does it work for you?

Jussi Pakkanen (jpakkane)
Changed in cuneiform-linux:
status: New → Fix Committed
Revision history for this message
Jakub Wilk (jwilk) wrote :

Sorry for late reply.
The currently commited fix doesn't work, unforunately. I attach a patch with necessary corrections.

Yury V. Zaytsev (zyv)
Changed in cuneiform-linux:
status: Fix Committed → Confirmed
Jussi Pakkanen (jpakkane)
Changed in cuneiform-linux:
status: Confirmed → Fix Committed
Revision history for this message
daniel (daniel-schmid-engineering) wrote : Re: [Cuneiform] [Bug 640038] Re: i386 assembly

Daniel Wildermuth ist bis zum 15.Oktober 2010 nicht im Büro. In dringenden
Fällen bitte Marco Schmid(<email address hidden>) kontaktieren.

Daniel Wildermuth is out of Office until October 15th 2010. Is it urgent ?
Then please contact Marco Schmid(<email address hidden>))

Revision history for this message
daniel (daniel-schmid-engineering) wrote : Re: Re: [Cuneiform] [Bug 640038] Re: i386 assembly

Daniel Wildermuth ist bis zum 15.Oktober 2010 nicht im Büro. In dringenden
Fällen bitte Marco Schmid(<email address hidden>) kontaktieren.

Daniel Wildermuth is out of Office until October 15th 2010. Is it urgent ?
Then please contact Marco Schmid(<email address hidden>))

Revision history for this message
daniel (daniel-schmid-engineering) wrote : Re: Re: Re: [Cuneiform] [Bug 640038] Re: i386 assembly

Daniel Wildermuth ist bis zum 15.Oktober 2010 nicht im Büro. In dringenden
Fällen bitte Marco Schmid(<email address hidden>) kontaktieren.

Daniel Wildermuth is out of Office until October 15th 2010. Is it urgent ?
Then please contact Marco Schmid(<email address hidden>))

Jussi Pakkanen (jpakkane)
Changed in cuneiform-linux:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.