DuplicationError caught in admin when creating app providing wrong error message when error is in app

[jhsware]

in admin/view.py the code

       try:
           new_app = app()
           grok.notify(grok.ObjectCreatedEvent(new_app))
           self.context.root[name] = new_app
           self.flash(u'Added %s `%s`.' % (application, name))
       except DuplicationError:
           self.flash(u'Name `%s` already in use. '
                      u'Please choose another name.' % (name,))

Catches errors in application and hides the traceback. It would be nicer to have:

       if self.context.root.has_key(name):
           self.flash(u'Name `%s` already in use. '
                      u'Please choose another name.' % (name,))
 else:
           new_app = app()
           grok.notify(grok.ObjectCreatedEvent(new_app))
           self.context.root[name] = new_app
           self.flash(u'Added %s `%s`.' % (application, name))

[Uli Fouquet (uli-gnufix)]

It only catches DuplicationErrors but I understand that also these can happen during application creation.

[jhsware (sebastian-urbantalk)]

Correct. In my case it was code running in the app.__init__() method which caused a DuplicationError and it took a while to figure out what was wrong.

If we want to catch the error, I think it still should output to the error log. Our first reaction was to look in the error log to see what might have gone wrong.