ec2 land: do not include already fix-committed or fix-released bugs in commit message
Bug #638468 reported by
Robert Collins
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Jonathan Lange |
Bug Description
I use the same branch from time to time for doing a series of work.
If you look at e.g. https:/
The qa bot is doing the right thing: the landings from me have a [bug=xxx] header including that bug, *but* none of the new work on that branch referenced that bug.
If you look at the MP's for my oops branch, you can see its listing all the bugs, not just the unfixed bugs: I suspect ec2 land is picking up too many bugs, or picking up bugs that are fixed-released/
Related branches
lp:~jml/launchpad/various-ec2-fixes
- j.c.sackett (community): Approve
-
Diff: 278 lines (+102/-24)5 files modifiedlib/devscripts/autoland.py (+19/-5)
lib/devscripts/ec2test/builtins.py (+26/-8)
lib/devscripts/ec2test/instance.py (+7/-2)
lib/devscripts/ec2test/tests/test_remote.py (+6/-2)
lib/devscripts/tests/test_autoland.py (+44/-7)
summary: |
- do not include already fix-committed or fix-released bugs in pqm mail + ec2 land: do not include already fix-committed or fix-released bugs in + commit message |
Changed in launchpad-foundations: | |
status: | New → Triaged |
tags: | added: new-merge-workflow |
tags: | added: build-infrastructure |
tags: | added: ec2land ec2test |
Changed in launchpad: | |
status: | Triaged → In Progress |
assignee: | nobody → Jonathan Lange (jml) |
tags: |
added: qa-untestable removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I've updated https:/ /dev.launchpad. net/QAProcessCo ntinuousRollout s adding a note that ec2 land should discard Fix Released and Fix Committed bugs. If the landing isn't explicitly set as no-qa and ec2 land finds no bugs, the command should fail.
This change is required because devels are reusing branches and ec2 land uses the bugs linked to branches, not linked to MPs (there's no such thing, I believe). Because of that tagger script is tagging a lot of already fix released bugs, retargeting milestones and lots of similar things that can make the whole QA process a mess.