ec2 land: do not include already fix-committed or fix-released bugs in commit message

Bug #638468 reported by Robert Collins
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Jonathan Lange

Bug Description

I use the same branch from time to time for doing a series of work.

If you look at e.g. https://bugs.edge.launchpad.net/launchpad-foundations/+bug/632022, you'll see that it is being touched by the qa bot to make it 'qa-needstesting' after being made qa-ok.

The qa bot is doing the right thing: the landings from me have a [bug=xxx] header including that bug, *but* none of the new work on that branch referenced that bug.

If you look at the MP's for my oops branch, you can see its listing all the bugs, not just the unfixed bugs: I suspect ec2 land is picking up too many bugs, or picking up bugs that are fixed-released/fix-committed and including them inappropriately.

Related branches

Ursula Junque (ursinha)
summary: - do not include already fix-committed or fix-released bugs in pqm mail
+ ec2 land: do not include already fix-committed or fix-released bugs in
+ commit message
Ursula Junque (ursinha)
Changed in launchpad-foundations:
status: New → Triaged
Revision history for this message
Ursula Junque (ursinha) wrote :

I've updated https://dev.launchpad.net/QAProcessContinuousRollouts adding a note that ec2 land should discard Fix Released and Fix Committed bugs. If the landing isn't explicitly set as no-qa and ec2 land finds no bugs, the command should fail.

This change is required because devels are reusing branches and ec2 land uses the bugs linked to branches, not linked to MPs (there's no such thing, I believe). Because of that tagger script is tagging a lot of already fix released bugs, retargeting milestones and lots of similar things that can make the whole QA process a mess.

Changed in launchpad-foundations:
importance: Undecided → High
Ursula Junque (ursinha)
tags: added: new-merge-workflow
Jonathan Lange (jml)
tags: added: build-infrastructure
Jonathan Lange (jml)
tags: added: ec2land ec2test
Revision history for this message
Jonathan Lange (jml) wrote :

Presumably it only matters if they are "Fix Committed" or "Fix Released" on the 'launchpad' bug target?

Jonathan Lange (jml)
Changed in launchpad:
status: Triaged → In Progress
assignee: nobody → Jonathan Lange (jml)
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :
Changed in launchpad:
milestone: none → 11.04
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Jonathan Lange (jml)
tags: added: qa-untestable
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.