Cannot update the flat network IP address list

[Ryan Lucio]

The network node code in trunk that handles adding the flat network ips to the redis db does not allow for updates once the ip list has been created initially.

nova/network/service.py:167

        if not redis.exists('ips') and not len(redis.keys('instances:*')):
            for fixed_ip in FLAGS.flat_network_ips:
  redis.sadd('ips', fixed_ip)

I understand that if the ip list already exists in redis it should not necessarily be appended to.. but the whole set should be able to be deleted and updated if the ip list provided by the configuration does not match the one in redis.

To reproduce:

1) Create a list of ips for a flat network:

--flat_network_ips=192.168.10.220,192.168.10.221,...

2) Start network node with this flag

3) launch instance

4) terminate instance

5) Verify ips=... set existence in redis.

6) stop network node, and create a new ip list:

--flat_network_ips=10.1.1.1,10.1.1.2,....

7) restart network node

8) launch instance (you will see an ip from the original list still)

9) terminate instance

10) Verify that ips=... set has not changed.

[Thierry Carrez (ttx)]

I think this was covered by the "nova-manage network create" transition in bexar, we no longer use --flat_network_ips.
Please reopen if you disagree.