Some reviews created without a reviewer
Bug #636688 reported by
Tim Penhey
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Medium
|
Ian Booth | ||
Bug Description
If no reviewer is passed in to the addLandingTarget method, then a review should be requested from the default review team of the target branch.
Also while doing this change, the default reviewer added to the form should be removed. This way the user only needs to specify a reviewer if it is not the default.
Related branches
lp:~wallyworld/launchpad/reviews-without-reviewer
- Tim Penhey (community): Approve
-
Diff: 1291 lines (+351/-178)20 files modifiedlib/lp/code/browser/branch.py (+4/-14)
lib/lp/code/browser/tests/test_branchmergeproposal.py (+69/-28)
lib/lp/code/browser/tests/test_branchmergeproposallisting.py (+3/-2)
lib/lp/code/doc/branch-merge-proposal-notifications.txt (+9/-4)
lib/lp/code/interfaces/branchmergeproposal.py (+4/-1)
lib/lp/code/mail/codehandler.py (+50/-39)
lib/lp/code/mail/tests/test_branchmergeproposal.py (+23/-17)
lib/lp/code/mail/tests/test_codehandler.py (+7/-4)
lib/lp/code/model/branch.py (+4/-0)
lib/lp/code/model/tests/test_branch.py (+33/-0)
lib/lp/code/model/tests/test_branchmergeproposal.py (+36/-36)
lib/lp/code/model/tests/test_codereviewvote.py (+8/-7)
lib/lp/code/stories/branches/xx-branchmergeproposals.txt (+35/-16)
lib/lp/code/stories/branches/xx-code-review-comments.txt (+4/-6)
lib/lp/code/stories/branches/xx-reviewing.txt (+3/-1)
lib/lp/code/stories/webservice/xx-branchmergeproposal.txt (+3/-1)
lib/lp/code/templates/branch-register-merge.pt (+30/-0)
lib/lp/code/tests/helpers.py (+9/-0)
lib/lp/code/windmill/tests/test_branchmergeproposal_review.py (+12/-0)
lib/lp/testing/factory.py (+5/-2)
| Changed in launchpad-code: | |
| assignee: | nobody → Ian Booth (wallyworld) |
| Changed in launchpad-code: | |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #1 |
| Changed in launchpad-code: | |
| milestone: | none → 10.11 |
| tags: | added: qa-needstesting |
| Changed in launchpad-code: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad-code: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r11857 <http://