branchChanged method fails to create a scan job after scan failure
Bug #636674 reported by
Tim Penhey
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Medium
|
Tim Penhey | ||
Bug Description
If the branch failed to scan for some reason the last_scanned_id isn't updated.
The branchChanged method only creates a branch scan job if the new tip revision id is different to the last_mirrored_id. The method should check the last_scanned_id instead.
Related branches
lp:~thumper/launchpad/fix-branchChanged-scan-request
- Robert Collins (community): Approve
-
Diff: 49 lines (+21/-7)2 files modifiedlib/lp/code/model/branch.py (+2/-2)
lib/lp/code/model/tests/test_branch.py (+19/-5)
| Changed in launchpad-code: | |
| assignee: | nobody → Tim Penhey (thumper) |
| milestone: | none → 10.10 |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #1 |
| tags: | added: qa-needstesting |
| Changed in launchpad-code: | |
| status: | Triaged → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad-code: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r11591 <http://