PATCH: Enqueue'd items disappear from Queue without playing

[Dave Gilbert]

I've got an 'Entire Library' playlist running on Shuffle and decide I want to listen to a particular track,
so I Click the collection side tab, and search for the song I want, Then I right click on the song and hit Enqueue.

A tab pops up next to 'Entire Library' entitled 'Queue' and the selected track appears in there, however when my current track finishes, instead of playing the Queue it just picks another one from the Entire Library and the Enqueued song disappears from the Queue.

If I double click on the track and force it to play it then it plays, so the track is OK.

This is on an exaile bzr updated today (rev 3731 is shown as top).

Dave

[Ciaran Liedeman (ciaran-liedeman)]

To reproduce:
Begin playing any playlist(p1) then right click on any song and select enque. The song can be from the playlist or library
The Queue playlist will now contain a single track, go to next track and the single track in queue will be skipped and the next
track in the original playlist(p1) will begin playing.

Before clicking next track enque more than a single track, all the tracks in the Queue playlist will play normally except for the last one which will be skipped.

The problem is in xl/player/queue.py next function. line 97
The last track in the Queue playlist is popped correctly off the track list but the line
$ self.current_position = 0
causes an index exception to be raised in xl/playlist.py set_current_position line 753: "Cannot set position past end of playlist"

[Dustin Spicuzza (dustin-virtualroadside)]

Ciaran: I'm not sure why nobody has fixed this yet, particularly since you said exactly what was breaking in your comment. I found this bug and the solution independently, but with the same result: the queue implementation is slightly broken.

I've attached a patch, and pushed this patch to my dj_improvements branch. I'm expecting the exaile devs will take all of my fixes in this branch and put them into the next release.