In a filtered view, Rosetta skips messages when saving

Bug #63557 reported by Malcolm Parsons
32
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Unassigned

Bug Description

When translating with the "untranslated" filter on.
Messages 1-10 are displayed.
The user translates these, and presses "save & continue".
The URL then contains "start=10".
So Rosetta displays untranslated messages 11-20.
These are actually messages 21-30, as the first 10 messages are now translated.
Messages 11-20 have been skipped.
...
When you've translated the last message you get told
"There are no messages that match this filtering. Translation status: English (United Kingdom) 50%"

Maybe the start value in the URL should be decreased by the number of strings that were translated.

Revision history for this message
Diogo Matsubara (matsubara) wrote :

Indeed, this is confusing.

Changed in rosetta:
status: Unconfirmed → Confirmed
Revision history for this message
Andre Noel (andrenoel) wrote :

"Maybe the start value in the URL should be decreased by the number of strings that were translated."
It would be nice. Alternatively, if start > total strings it would go back to start=0.

Revision history for this message
Данило Шеган (danilo) wrote :

Some discussion in bug #81490 as well.

Revision history for this message
Mikel Pascual Aldabaldetreku (mpascual) wrote :

yeah

this is very annoying, and makes much more long to translate huge packages (keeping the translator go forth and back)

this should be easy to fix (and would help a lot), either doing "new_start=old_start+batch-translated" as Malcom said.

Changed in rosetta:
importance: Undecided → High
Curtis Hovey (sinzui)
Changed in rosetta:
assignee: nobody → sinzui-is
milestone: none → 1.2.1
Revision history for this message
Curtis Hovey (sinzui) wrote :

The branch to fix this is in review.

Changed in rosetta:
status: Confirmed → In Progress
Revision history for this message
Curtis Hovey (sinzui) wrote :

Fixed in RF 5538.

Changed in rosetta:
status: In Progress → Fix Committed
Revision history for this message
Curtis Hovey (sinzui) wrote :

Fixed released in Launchpad 1.2.1.

Changed in rosetta:
status: Fix Committed → Fix Released
Revision history for this message
Gintautas Miliauskas (gintas) wrote :

This bug has been fixed for the "untranslated messages" filter, but not for "changed messages". I just compared the behaviours for these two filters and it is indeed different. Other filters may also have the problem. Here's how to reproduce the problem:

1. Open a package with X (X>20) changed strings in Launchpad Translations
2. Revert all 10 strings on first page to packaged versions.
3. Press "Save & Continue"
4. The label at the top says "11 → 20 of X-10 results", whereas it should say "1 → 10 of X-10 results".

Revision history for this message
Curtis Hovey (sinzui) wrote :

This should be files as a new bug because the rules for identifying the changed messages will be different. This will be easier to fix since the new rules can be added to blocks that adjust the batch starting numbers.

Revision history for this message
Gintautas Miliauskas (gintas) wrote :

As requested, I filed the problem as a separate bug: https://bugs.launchpad.net/rosetta/+bug/206739

Curtis Hovey (sinzui)
Changed in launchpad:
assignee: Curtis Hovey (sinzui) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.