Admin edits of user account details can be overwritten by open session

[Richard Mansfield]

If an admin edits a user on the admin edit user page, and that user is currently logged in, then the changes made by the admin can be overwritten the next time that user browses around on the site and their session details are saved to the database.

Perhaps, saving the form on the edit user page should call remove_user_sessions for the edited user (like when suspending a user). It would be nice if the admin was given a warning ("if you submit this form then <username> will be logged out") whenever the edited user has a session that hasn't expired.

[Eugene (eugenev)]

Hi Richard,

Would the attached patch do the trick. I have added a warning note to the top of the form and added the functionality that will remove the edited user's session upon form submit.

Cheers!

[Richard Mansfield (richard-mansfield)]

Looks good to me