Don't delete BranchRevision objects using the id
Bug #633758 reported by
Tim Penhey
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Medium
|
Tim Penhey |
Bug Description
BranchRevision.id is being deprecated then removed. To ensure an orderly removal we need to stop referring to the id attribute of the BranchRevision object.
Related branches
lp:~thumper/launchpad/deleting-individual-branch-revisions
- Paul Hummer (community): Approve
-
Diff: 443 lines (+109/-88)10 files modifiedlib/canonical/config/schema-lazr.conf (+1/-0)
lib/lp/code/configure.zcml (+0/-11)
lib/lp/code/doc/revision.txt (+5/-18)
lib/lp/code/interfaces/branch.py (+6/-0)
lib/lp/code/interfaces/branchrevision.py (+3/-8)
lib/lp/code/model/branch.py (+13/-9)
lib/lp/code/model/branchrevision.py (+4/-18)
lib/lp/code/model/tests/test_branch.py (+56/-2)
lib/lp/codehosting/scanner/bzrsync.py (+20/-17)
lib/lp/codehosting/scanner/tests/test_bzrsync.py (+1/-5)
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad-code: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r11534 <http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ stable/ revision/ 11534>.