Mixxx

Wasted CPU time in wvumeter.cpp

Bug #632017 reported by jus
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Medium
RJ Skerry-Ryan
Mixxx 1.8.0

Bug Description

Default_Falltime for peaks (VUmeter peaks for channel1/2 + master in the GUI) is defined in wvumeter.cpp (around line 27).
Timer updates way to often at 10 ms . If set to 80-100 ms, Mixxx need more then 10% less CPU (idle) here (trunk Mac OSX 10.5.8).
Falltime can be defined per skin in the corresponding skin.xml , but no skin actually use it (will fix that later on).
Changing the hardcoded default value might be a still necessary as fallback.

See original description

Related branches

lp:mixxx/1.8 (Merged)
jus (jus)
description: updated
jus (jus)
description: updated
Revision history for this message
jus (jus) wrote :

Skins updated as of http://bazaar.launchpad.net/~jus/mixxx/skins/revision/2395

RJ Skerry-Ryan (rryan)
Changed in mixxx:
importance: Undecided → Medium
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

It turns out that the timer was completely unnecessary and I've removed it from the 1.8 branch. This saves the 10ms timer across all 3 VU meters and causes a noticeable CPU usage drop for me as well.

Good eye Jus!

Changed in mixxx:
assignee: nobody → RJ Ryan (rryan)
milestone: none → 1.8.0
status: New → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/5503

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.