Provide minimal desktop theme for SSO

Bug #631573 reported by Matthew Paul Thomas
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical SSO provider
Fix Released
High
David Owen
software-center (Ubuntu)
Invalid
Undecided
Unassigned

Bug Description

Binary package hint: software-center

software-center trunk r1116, Ubuntu Maverick

1. Navigate to Fluendo DVD Player, and choose "Buy".
2. In the sign-on screen that appears, click a link, e.g. "Terms of Service".
3. Try to return to the sign-on screen.

What happens: You can't.

What should happen: either
* there should not be any links on the embedded version of the sign-on screen at all (preferred); or
* it should be possible to get from any linked screen back to the sign-on screen somehow.

Related branches

Revision history for this message
Stuart Metcalfe (stuartmetcalfe) wrote :

We should be able to use the same desktop light styled theme as the payment service. This should not contain links to external pages. It should also not provide a language picker as this will be embedded into desktop apps and pick up the user's default automatically.

summary: - Can't return from following any link on the sign-on screen
+ Provide minimal desktop theme for SSO
Changed in software-center (Ubuntu):
status: New → Invalid
Changed in canonical-identity-provider:
status: New → Confirmed
milestone: none → 2.9.0
Julien Funk (jaboing)
Changed in canonical-isd-qa:
milestone: none → canonical-identity-provider+2.9.0
Changed in canonical-identity-provider:
importance: Undecided → High
David Owen (dsowen)
Changed in canonical-identity-provider:
milestone: 2.9.0 → for-10.9
Changed in canonical-identity-provider:
milestone: for-10.0 → 1-commitment
Changed in canonical-identity-provider:
milestone: 1-commitment → 2-implementation
assignee: nobody → Anthony Lenton (elachuni)
Changed in canonical-identity-provider:
status: Confirmed → In Progress
Revision history for this message
Anthony Lenton (elachuni) wrote :

The linked branch implements a basic embedded theme.

There's a new context processor that inspects the trust_root during OpenID transactions and lets the templates know if they should behave as embedded. You currently just have one setting to select one trust root you'd like to show as embedded. A better way to do this would be to add a flag in OpenIDRPConfig to decide if each RP should be treated as embedded or not.

The embedded theme itself is based on jblount's mobile style sheet, with a couple of changes:
 - External links that were easily removed were removed.
 - All remaining external links are added a target="_blank" via javascript

David Owen (dsowen)
Changed in canonical-identity-provider:
assignee: Anthony Lenton (elachuni) → David Owen (dsowen)
David Owen (dsowen)
Changed in canonical-identity-provider:
milestone: 2-implementation → 3-internal-qa
status: In Progress → Fix Committed
Revision history for this message
David Owen (dsowen) wrote :

To test, use the built-in test consumer. This will enable embedded mode on SSO proper.

Revision history for this message
David Owen (dsowen) wrote :

Test addendum:

In embedded mode, the site will be styled a little differently. First off, it should support a narrower screen size. I set my browser window to 480px to test it, for example. Second, you should not be able to navigate yourself into a corner by only clicking on the screen (i.e. don't user your browsers forward/backward buttons).

Revision history for this message
Anthony Lenton (elachuni) wrote :

Notes to QA:

This bug requires particular OpenID transactions to happen with a slightly different theme. You'll recognize this new theme because it should work better on narrow screens (down to 640px wide) and have considerably less external links to reduce the ways of abandoning the SSO site while running inside an embedded browser.

At the moment the way to select which OpenID transactions get the embedded theme is via a setting, that tells SSO to use the embedded theme for all transactions for a particular RP.

To test:
1) Check that the EMBEDDED_TRUST_ROOT setting is set to the test consumer's trust root. Logging in with the test consumer should then show you the embedded theme. If you have another consumer available, verify that it doesn't use the embedded theme.
2) Check that EMBEDDED_TRUST_ROOT setting is set to anything else. Logging in with the test consumer should now use the standard theme.

Julien Funk (jaboing)
Changed in canonical-isd-qa:
status: New → In Progress
Julien Funk (jaboing)
Changed in canonical-isd-qa:
status: In Progress → Confirmed
Julien Funk (jaboing)
Changed in canonical-isd-qa:
status: Confirmed → In Progress
David Owen (dsowen)
Changed in canonical-identity-provider:
milestone: 3-internal-qa → 4-staging
David Owen (dsowen)
Changed in canonical-identity-provider:
milestone: 4-staging → 5-production
Revision history for this message
Dave Morley (davmor2) wrote :

This is currently disabled on production and needs to be revisited after the new SCA and pay hit production.

Changed in canonical-isd-qa:
status: In Progress → Incomplete
Changed in canonical-identity-provider:
status: Fix Committed → Fix Released
Changed in canonical-identity-provider:
milestone: 5-production → 2.9.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.