remove workaround for private Librarian files for launchpadlib clients
Bug #629804 reported by
Abel Deuring
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Abel Deuring |
Bug Description
It is at present not possible to access the content of restricted Librarian files via the webservice API. The branch lp:~adeuring/launchpad/bug-620458-private-bugattachments-api-access fixes this for machines in our data center in a quite hackish, ugly way.
As the publicrestricte
To QA this, make sure an API client can access a restricted file on qastaging. I suggest filing a private bug and adding an attachment to it.
Related branches
lp:~lifeless/launchpad/librarian-filealiases
- Robert Collins (community): Approve
-
Diff: 307 lines (+16/-118)7 files modifiedlib/canonical/launchpad/browser/librarian.py (+3/-4)
lib/canonical/launchpad/rest/bytestorage.py (+0/-28)
lib/canonical/launchpad/webapp/servers.py (+11/-14)
lib/canonical/launchpad/zcml/webservice.zcml (+0/-13)
lib/lp/bugs/interfaces/bugattachment.py (+2/-2)
lib/lp/bugs/stories/webservice/xx-bug.txt (+0/-40)
lib/lp/services/fields/__init__.py (+0/-17)
lp:~adeuring/launchpad/librarian-filealiases
- Graham Binns (community): Approve (code)
-
Diff: 280 lines (+16/-109)6 files modifiedlib/canonical/launchpad/browser/librarian.py (+13/-14)
lib/canonical/launchpad/rest/bytestorage.py (+0/-28)
lib/canonical/launchpad/zcml/webservice.zcml (+0/-13)
lib/lp/bugs/interfaces/bugattachment.py (+2/-2)
lib/lp/bugs/stories/webservice/xx-bug.txt (+1/-41)
lib/lp/services/fields/__init__.py (+0/-11)
lp:~gary/launchpad/revert12041-2
- Gary Poster (community): Approve
- Diff: 0 lines
lp:~adeuring/launchpad/webservice-access-to-private-bug-attamchments
- Leonard Richardson (community): Approve
- Graham Binns (community): Approve (code)
-
Diff: 85 lines (+14/-33)2 files modifiedlib/lp/bugs/browser/tests/test_bugattachment_file_access.py (+12/-8)
lib/lp/testing/_webservice.py (+2/-25)
Changed in launchpad-foundations: | |
status: | New → Triaged |
importance: | Undecided → High |
summary: |
- implement access to private Librarian files for launchpadlib clients + remove workaround for private Librarian files for launchpadlib clients |
description: | updated |
Changed in launchpad-foundations: | |
assignee: | nobody → Robert Collins (lifeless) |
status: | Triaged → In Progress |
description: | updated |
tags: |
added: qa-bad removed: qa-needstesting |
Changed in launchpad-foundations: | |
assignee: | Robert Collins (lifeless) → nobody |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r12041 <http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ stable/ revision/ 12041>.