MockerTestCase fails to call restore when there's an exception

[John Evans]

This causes cascading test failures because objects that have been .replace'd in one test are still (bad leftover) mocks in subsequent tests.

See the attached patch for a fix.

[Gustavo Niemeyer (niemeyer)]

This should not be necessary, because the method is wrapped in this logic:

        def run_wrapper(*args, **kwargs):
            try:
                return run_method(*args, **kwargs)
            finally:
                self.__cleanup()

self.__cleanup() will call mocker.reset(), which does the restoring.

If you believe there's a problem in this logic, can you please provide a test case which demonstrates the problem?

[John Evans (lgastako)]

You are correct. I created a simplified test case to reproduce the issue we were encountering and was unable to reproduce it, so the problem must lie elsewhere in our test code. Sorry for the false alarm.

[Gustavo Niemeyer (niemeyer)]

No problem.

[John Evans (lgastako)]

BTW, Mocker is a great tool. We love it. Good work! :)