Better wording on Feed action for profile changes

Bug #628285 reported by Paul Everitt
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KARL3
Fix Released
Low
Tres Seaver

Bug Description

Nat wrote:

If you change your profile pic, feeds doesn’t seem to know how describe this action (see screenshot, 2nd item from the top). A profile pic change may need its own description: “Thomas Moroz changed his profile picture”. Same thing with an edit on the profile: “Thomas Moroz edited his profile” would be better than “Thomas Moroz edited Profile Thomas Moroz.”

Tags: m46ib2
Revision history for this message
Paul Everitt (paul-agendaless) wrote :
Revision history for this message
Tres Seaver (tseaver) wrote :

This won't land before the merge of the m46_integration branch.

Revision history for this message
Tres Seaver (tseaver) wrote :

WRT profile picture changes:

- The "add" event for the file is just like the event for adding
  any other content to the site: to implement a special "flavor"
  for this event, the subscriber would have to apply some
  grotty malherusitic.

- It would be more feasible to ensure that the "context" title and URL,
  which are normally those of the community, and are thus empty for this
  event, would be mapped to the URL and title of the profile. THe event
  as displayed would then look something like:

    <a href="...">Phred Phlyntsone</a> added a File <a href="..."
    >Photo of Phred Phlyntstone</a> in <a href="...">Phred Phlyntstone</a>.

  Likewise for updates.

WRT "edited his profile":

- AFAK we don't know the user's sex, which means we can't use a grammatically
  correct personal pronoun (I *despise* the "singular their").

Revision history for this message
Paul Everitt (paul-agendaless) wrote :

Added Nat as a subscriber so he could see comment #3. I agree with Tres's points. We can't do the personal pronoun, and it would be advisable to find a solution that didn't require the double-special-casing mentioned in the first point. I think Tres's suggestion gets much of what was asked for while keeping cost and longer term maintenance down.

Tres, go ahead and make the change you propose (doesn't have to be for today's rollout). If something bigger is needed, we can discuss it in isolation.

Revision history for this message
Nat Katin-Borland (nborland) wrote :

OK, sounds good. Why can't we get KARL to detect gender? :)

tags: added: m46ib2
removed: m46ib
Tres Seaver (tseaver)
Changed in karl3:
status: New → In Progress
Tres Seaver (tseaver)
Changed in karl3:
status: In Progress → Fix Committed
Revision history for this message
JimPGlenn (jpglenn09) wrote :

fixed

Changed in karl3:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.