[trunk] merge partner crashes

[Ferdinand]

Traceback (most recent call last):
  File "/home2/gass/OpenERP/trunk/openobject-server/bin/netsvc.py", line 431, in dispatch
    result = ExportService.getService(service_name).dispatch(method, auth, params)
  File "/home2/gass/OpenERP/trunk/openobject-server/bin/service/web_services.py", line 626, in dispatch
    res = fn(db, uid, *params)
  File "/home2/gass/OpenERP/trunk/openobject-server/bin/service/web_services.py", line 653, in exp_execute
    return self._execute(db, uid, wiz_id, datas, action, context)
  File "/home2/gass/OpenERP/trunk/openobject-server/bin/service/web_services.py", line 635, in _execute
    return wiz.execute(db, uid, self.wiz_datas[wiz_id], action, context)
  File "/home2/gass/OpenERP/trunk/openobject-server/bin/wizard/__init__.py", line 177, in execute
    res = self.execute_cr(cr, uid, data, state, context)
  File "/home2/gass/OpenERP/trunk/openobject-server/bin/wizard/__init__.py", line 72, in execute_cr
    action_res = action(self, cr, uid, data, context)
  File "/home2/gass/OpenERP/trunk/openobject-server/bin/addons/base_partner_merge/wizard/merge_partners.py", line 60, in _build_form
    filter_name[str(field['name'])] = str(field['field_description'])
UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in position 2: ordinal not in range(128)

[JMA(Open ERP) (jma-openerp)]

Hello Ferdinand,

Would you please apply the patch and notify us?

Thanks.

[Ferdinand (office-chricar)]

sorry no

Environment Information :
System : Linux-2.6.34-12-desktop-x86_64-with-SuSE-11.3-x86_64
OS Name : posix
LSB Version: core-2.0-noarch:core-3.2-noarch:core-4.0-noarch:core-2.0-x86_64:core-3.2-x86_64:core-4.0-x86_64:desktop-4.0-amd64:desktop-4.0-noarch:graphics-2.0-amd64:graphics-2.0-noarch:graphics-3.2-amd64:graphics-3.2-noarch:graphics-4.0-amd64:graphics-4.0-noarch
Distributor ID: SUSE LINUX
Description: openSUSE 11.3 (x86_64)
Release: 11.3
Codename: n/a
Operating System Release : 2.6.34-12-desktop
Operating System Version : #1 SMP PREEMPT 2010-06-29 02:39:08 +0200
Operating System Architecture : 64bit
Operating System Locale : en_US.UTF8
Python Version : 2.6.5
OpenERP-Client Version : 6.0dev
Last revision No. & ID :1528 codehost@crowberry-20100902035141-0kbr4u8siwoxmqbq
Traceback (most recent call last):
  File "/home2/gass/OpenERP/trunk/openobject-server/bin/netsvc.py", line 431, in dispatch
    result = ExportService.getService(service_name).dispatch(method, auth, params)
  File "/home2/gass/OpenERP/trunk/openobject-server/bin/service/web_services.py", line 626, in dispatch
    res = fn(db, uid, *params)
  File "/home2/gass/OpenERP/trunk/openobject-server/bin/service/web_services.py", line 653, in exp_execute
    return self._execute(db, uid, wiz_id, datas, action, context)
  File "/home2/gass/OpenERP/trunk/openobject-server/bin/service/web_services.py", line 635, in _execute
    return wiz.execute(db, uid, self.wiz_datas[wiz_id], action, context)
  File "/home2/gass/OpenERP/trunk/openobject-server/bin/wizard/__init__.py", line 177, in execute
    res = self.execute_cr(cr, uid, data, state, context)
  File "/home2/gass/OpenERP/trunk/openobject-server/bin/wizard/__init__.py", line 115, in execute_cr
    fields[val]['selection'][idx] = (key, trans(val2))
  File "/home2/gass/OpenERP/trunk/openobject-server/bin/wizard/__init__.py", line 113, in <lambda>
    trans = lambda x: translate(cr, res_name, 'selection', lang, x) or x
  File "/home2/gass/OpenERP/trunk/openobject-server/bin/tools/translate.py", line 121, in translate
    cr.execute('select value from ir_translation where lang=%s and type=%s and name=%s and src=%s', (lang, source_type, str(name), source))
  File "/home2/gass/OpenERP/trunk/openobject-server/bin/sql_db.py", line 74, in wrapper
    return f(self, *args, **kwargs)
  File "/home2/gass/OpenERP/trunk/openobject-server/bin/sql_db.py", line 123, in execute
    res = self._obj.execute(query, params)
ProgrammingError: operator does not exist: text = numeric
LINE 1: ...name=E'base_partner.merge,next,credit_limit' and src=32000.0
                                                               ^
HINT: No operator matches the given name and argument type(s). You might need to add explicit type casts.

[JMA(Open ERP) (jma-openerp)]

Hello Ferdinand,

The error was not raised due to the latter patch but it was an existing problem.

The problem came up when there were fields with none values in either of the partner.
In this scenario:
                      It happens only for few partners, where they have credit limit defined and the partner with whom you choose to merge does not have the credit limit field set to specified values.

Thank you for pointing this out.
I hope this patch will solve your issues.

Thanks.

[Ferdinand (office-chricar)]

Without testing various scenarios it seems to work now

[JMA(Open ERP) (jma-openerp)]

Hello Ferdinand,

It has been fixed by revision:
4951 <email address hidden>

Thank you for pointing this out.

[Dhruti Shastri(OpenERP) (dhs-openerp)]

Hello Ferdinand,

One more aspect where this wizard crashes,
i.e when we try to merge 2 similar partners(the partner itself with the same id).

It has been fixed by revision: 4957 <email address hidden>

Thank you.