DistroSeriesDifference can't blacklist current version
Bug #627957 reported by
Michael Nelson
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Medium
|
Michael Nelson |
Bug Description
Currently the model for DistroSeriesDif
After more discussion with users, we need to be able to blacklist a specific version of the package - implying that it will be automatically removed from the blacklist once a new version is detected. With the current model we can't do this.
I assume we'll delete the source_package_name column and make source_pub and parent_source_pub db-backed attributes rather than properties (as we'd originally planned).
Related branches
lp:~michael.nelson/launchpad/627957-differences-schema-update
- Stuart Bishop (community): Approve (db)
- Abel Deuring (community): Approve (code)
- Robert Collins: Pending (db) requested
-
Diff: 514 lines (+210/-53)7 files modifieddatabase/schema/comments.sql (+4/-1)
database/schema/patch-2208-12-0.sql (+17/-0)
lib/lp/registry/enum.py (+4/-4)
lib/lp/registry/interfaces/distroseriesdifference.py (+9/-2)
lib/lp/registry/model/distroseriesdifference.py (+77/-25)
lib/lp/registry/tests/test_distroseriesdifference.py (+92/-20)
lib/lp/testing/factory.py (+7/-1)
Changed in soyuz: | |
assignee: | nobody → Michael Nelson (michael.nelson) |
status: | Triaged → In Progress |
tags: |
added: qa-untestable removed: qa-needstesting |
Changed in soyuz: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
So I started the schema change as above yesterday, (adding source_ pub/parent_ source_ pub), but soon realised that I don't think we want that amount of redundancy. We'd need to ensure at a DB level that both publications reference the same source package name, and that the publications are for the derived/parent distro series respectively etc. AFAIK, this could only be done with triggers like this:
http:// pastebin. ubuntu. com/490866/
So unless I hear otherwise, I'll instead store source_ version/ parent_ source_ version so that we can remove blacklists for specific versions when they are updated (they will not be writeable outside of the DistroSeriesDif ference model).