Banshee appears twice in the sound menu

Bug #627037 reported by Bertrand Lorentz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
The Sound Menu
Fix Released
Medium
Conor Curran

Bug Description

While testing the sound menu integration with Banshee, I noticed that after registering Banshee, it would then appear twice, once as "Banshee" and once as "Banshee Media Player". See the attached screenshot.

The registration is done as follows :
  server.SetType ("music.banshee");
  server.DesktopFile ("/usr/share/applications/banshee-1.desktop");
  server.Show ();

I'm guessing it might be related to the content of the .desktop file, as Banshee has "Name=Banshee Media Player", whereas Rhythmbox has "Name=Rhythmbox"

Related branches

Revision history for this message
Bertrand Lorentz (bertrand-lorentz) wrote :
Revision history for this message
Conor Curran (cjcurran) wrote :

Hi Bertrand,

>The registration is done as follows :
> server.SetType ("music.banshee");
> server.DesktopFile ("/usr/share/applications/banshee-1.desktop");
> server.Show ();

That does seem to be problem alright. If you can get me something to test against I can fix this from my end.

Changed in indicator-sound:
assignee: nobody → Conor Curran (cjcurran)
Conor Curran (cjcurran)
Changed in indicator-sound:
importance: Undecided → Medium
Revision history for this message
Bertrand Lorentz (bertrand-lorentz) wrote :

Here's a gzip file of the Sound Menu extension binary which should allow you to reproduce the problem. You need to have Banshee 1.7.4 or above and follow these steps :
1. Gunzip the file
2. Copy the .dll to ~/.config/banshee-1/addins/
3. Make sure the indicate-sharp package is installed
4. Start Banshee
5. Enable the Sound Menu extension in Edit > Preferences > Extensions
 -> Banshee appears as "Banshee" in the sound menu
6. Quit banshee
7. Make sure Banshee is listed in ~/.cache/indicators/sound/familiar-players-db.keyfile
8. Restart the indicator-sound-service
 -> Banshee is now listed as "Banshee Media Player"
9. Start Banshee
 -> Banshee is now also listed as "Banshee", so you have the situation shown in the screenshot.

Conor Curran (cjcurran)
Changed in indicator-sound:
status: New → In Progress
milestone: none → 0.4.4
Revision history for this message
Conor Curran (cjcurran) wrote :

Bertand, followed those instructions but no registration :(
The mpris interface came up nicely but no indicate noise ?

Revision history for this message
Cody Russell (bratsche) wrote :

I get to #5 on the list.. I enabled the extension in Banshee, but I did not see Banshee listed in the sound indicator at that point. When I exit Banshee I also don't find it listed in that file .cache/indicators/sound/familiar-players-db.keyfile

Revision history for this message
Cody Russell (bratsche) wrote :

And a little more serious issue is, I enabled the Sound Menu extension.. then Banshee's systray disappeared, as you would expect. But when I disable the Sound Menu extension I still don't see Banshee in the systray. It's easy to re-enable, but is there any chance that could be automated by the extension? Seems potentially confusing to users.

Revision history for this message
Bertrand Lorentz (bertrand-lorentz) wrote :

Here's a new version of the extension binary. The only differences are that the "Show Banshee in sound menu" preference is enabled by default, and it writes a log message when trying to register.

Please replace the previous version of the .dll with the content of that gzip file, run "banshee --debug" and post the output here

Revision history for this message
jan2ary (jan2ary) wrote :

I have no entry for banshee in the sound menu but for rhythmbox only.
Where can I find the indicate-sharp package? I already installed packages listed by apt-cache:

$ apt-cache search indicate-sharp
libindicate-gtk0.1-cil - CLI bindings for libindicate-gtk2
libindicate-gtk0.1-cil-dev - CLI bindings for libindicate-gtk4 - development files
libindicate0.1-cil - CLI bindings for libindicate4
libindicate0.1-cil-dev - CLI bindings for libindicate4 - development files

but I have the following message while starting banshee with --debug:

...
** (Banshee:6597): WARNING **: The following assembly referenced from /home/andriy/.config/banshee-1/addins/Banshee.SoundMenu.dll could not be loaded:
     Assembly: indicate-sharp (assemblyref_index=9)
     Version: 0.4.1.0
     Public Key: 2e8e49ba7d172cb0
The assembly was not found in the Global Assembly Cache, a path listed in the MONO_PATH environment variable, or in the location of the executing assembly (/home/andriy/.config/banshee-1/addins/).

** (Banshee:6597): WARNING **: Could not load file or assembly 'indicate-sharp, Version=0.4.1.0, Culture=neutral, PublicKeyToken=2e8e49ba7d172cb0' or one of its dependencies.
...

Revision history for this message
Bertrand Lorentz (bertrand-lorentz) wrote :

@jan2ary :
You need libindicate0.1-cil version 0.4.1, as the binary was built against this version. Which version do you have ?
You might also prefer to way a bit for a proper banshee-extension-soundmenu package, which should be making its way to Maverick

Conor Curran (cjcurran)
Changed in indicator-sound:
status: In Progress → Fix Committed
Revision history for this message
jan2ary (jan2ary) wrote :

$ apt-cache policy libindicate0.1-cil
libindicate0.1-cil:
  Installed: 0.4.2-0ubuntu1
  Candidate: 0.4.2-0ubuntu1
  Version table:
 *** 0.4.2-0ubuntu1 0
        500 http://archive.ubuntu.com/ubuntu/ maverick/main amd64 Packages
        100 /var/lib/dpkg/status

Conor Curran (cjcurran)
Changed in indicator-sound:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.