ftps support using lftp (ftpsbackend)

Bug #626915 reported by Marcel Pennewiß
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Duplicity
Fix Released
Medium
Unassigned

Bug Description

Hi,

this patch adds a new backend (ftpsbackend) which uses lftp. lftp (compared to ncftp) supports ftps (using gnutls or openssl-libs) as well as IPv6.

Because i'm neither a python pro nor a lftp pro this patch is a "works-for-me"-solution.

Known problems:
 - the destination directory will not be created if it missing while lftp has no support for automatic creation (afaik)

This patch works with duplicity-0.6.09.

Revision history for this message
Marcel Pennewiß (mape2k) wrote :
Revision history for this message
Marcel Pennewiß (mape2k) wrote :

depending on the defaults of lftp maybe we should also add some new values for ssl-enabled connections
...
os.write(self.tempfile, "set ftp:ssl-allow true\n")
os.write(self.tempfile, "set ftp:ssl-protect-data true\n")
os.write(self.tempfile, "set ftp:ssl-protect-list true\n")
...

Martin Pool (mbp)
Changed in duplicity:
status: New → In Progress
Revision history for this message
Martin Pool (mbp) wrote :

To me the patch looks basically reasonable. It seems like it would need doc and news updates. The code says this is an implementation for FTP which is I guess wrong - this is FTP-over-SSL.

Changed in duplicity:
importance: Undecided → Medium
assignee: nobody → Kenneth Loafman (kenneth-loafman)
milestone: none → 0.7.00
Revision history for this message
edso (ed.so) wrote :

we should consider to make it an alternative to ncftp. So people have an alternative ftp backend in case ncftp for some weird reason does not work in combination with their target ftpd.

maybe lftp+ftp[s] vs ncftp+ftp... ede

Revision history for this message
edso (ed.so) wrote :
Changed in duplicity:
milestone: 0.7.00 → 0.6.12
Changed in duplicity:
assignee: Kenneth Loafman (kenneth-loafman) → nobody
status: In Progress → Fix Committed
Changed in duplicity:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.