exception if fields.py if no _context

[Jim Norman]

I made this change some time ago, and no longer have the traceback.

An exception is thrown in osv/fields.py if self._context is False

The following change fixes the problem:

=== modified file 'bin/osv/fields.py'
--- bin/osv/fields.py 2010-08-13 00:23:21 +0000
+++ bin/osv/fields.py 2010-08-20 18:52:39 +0000
@@ -428,7 +428,10 @@
             context = {}
         if self._context:
             context = context.copy()
- context.update(self._context)
+ try:
+ context.update(self._context)
+ except:
+ pass
          if not values:
            values = {}

Revision is 2572, trunk

[xrg (xrg)]

On Saturday 28 August 2010, you wrote:
> I made this change some time ago, and no longer have the traceback.
> context = context.copy()
> - context.update(self._context)
> + try:
> + context.update(self._context)
> + except:
> + pass
> if not values:
> values = {}
>

Just a remark of Pythonic twist:

*Please, avoid catching with "except:", but use "except Exception:" instead. *

The reason is that the first would catch KeyboardInterrupt and SystemExit,
which should never be handled in code like that.

[Albert Cervera i Areny - http://www.NaN-tic.com (albert-nan)]

A Dissabte, 28 d'agost de 2010, xrg va escriure:
> *Please, avoid catching with "except:", but use "except Exception:"
> instead. *

Well, I don't think try: except: is very appropiate here, even less if you try
to catch all exceptions. I'd simply ensure context is always a dictionary
before executing the statement...

--
Albert Cervera i Areny
http://www.NaN-tic.com
OpenERP Partners
Mòbil: [phone]

http://twitter.com/albertnan
http://albert-nan.blogspot.com

[Borja López Soilán (NeoPolus) (borjals)]

Instead of the try...except I would just do:

if context and self._context:
    context.update(self._context)

[Jim Norman (jim-jsnorman)]

I agree with Borja's recommendation.

[Anup(SerpentCS) (anup-serpent)]

Hello Guys,

   It has been fixed by revision 2877 <email address hidden>

Thanks a lot for your contributions.
We really do appreciate that. Keep posting.