Credentials extraction mechanism should use ICredentialsFactory

Bug #625862 reported by Laurens Van Houtven
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
txOAuth
Opinion
Wishlist
Unassigned

Bug Description

The credential extraction interface in lp:~lvh/txoauth/client-credential-extraction, while functional, doesn't do the right Twisted thing. Instead, it should provide you with an implementation of ICredentialsFactory.

http://twistedmatrix.com/documents/10.0.0/api/twisted.web.iweb.ICredentialFactory.html

Tags: interface
Revision history for this message
Laurens Van Houtven (lvh) wrote :

The reason we want all things that turn t.w.iweb.Request into ICredentials to use ICredentialsFactory is so we can use HTTPAuthSessionWrapper as described here:

http://jcalderone.livejournal.com/53074.html

Revision history for this message
Laurens Van Houtven (lvh) wrote :

This will affect the tests, since they will now need to raise LoginFailed as opposed to TypeError.

Changed in txoauth:
status: New → Won't Fix
status: Won't Fix → Opinion
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.