check xml consistency during loading

[Ferdinand]

IMHO modules which will create runtime errors due to invalid xml coding like
https://bugs.launchpad.net/openobject-server/+bug/623845
shouldn't be loaded.
a check must be possible at load time

[Nhomar - Vauxoo (nhomar)]

Both bugs aren't the same Ferdinand?, if is yes please mark as duplicated,

IMHO is the same Idea and I tottally agree with you... _better_ debug for loading xml file.

regards!

[Ferdinand (office-chricar)]

No they are similar but IMHO not the same

Views can be modified in "Administration/Customization/User Interface", and if not checked (IIRC) it's possible to store there wrong code. - for that you need a good debugging message.

BTW - Koo "Modules/Edit View" does not allow to save malformed views. (didn't try with WEB-Client)

nevertheless I think If a view is updated all dependant modules / views must be checked, like doing an update of an module

[Nhomar - Vauxoo (nhomar)]

Ok. In this case, this is a bug in client side?,
I mean, we need to be able in clients check the view to be saved, even i think it should be checked at least in structure fields called or views inherited on server side _base module_ .... I'm talking around th same issue?

 with web client you can save a malformed view too! you are right,

[Ferdinand (office-chricar)]

On Mittwoch 25 August 2010 15:16:22 you wrote:
> Ok. In this case, this is a bug in client side?,
> I mean, we need to be able in clients check the view to be saved, even i
> think it should be checked at least in structure fields called or views
> inherited on server side _base module_ .... I'm talking around th same
> issue?
>
> with web client you can save a malformed view too! you are right,

SO this shouldn't be possible, the solution can obviously be found in Koo

Please Albert any hints for this?

Best Regards

ChriCar Beteiligungs- und Beratungs- GmbH
http://www.chricar.at/ChriCar/index.html
Dr. Ferdinand Gassauer
Official Tiny Partner

[Olivier Dony (Odoo) (odo-openerp)]

The server does not allow saving malformed views at all when you are editing them live. This is not a client-side feature

As for validating all views in a module, doing so could add a prohibitive delay during module installation, and would not even be 100% sure to catch all cases.
We do have a continuous integration server that validates all views by rendering them and warns about incorrect ones.

For the rest I do agree that we should improve debugging messages during XML construction/inheritance, but that's another bug report :-)

[Cristian Salamea (ovnicraft)]

Yes i test it and trying as admin user save a wrong-formed XML system give me the error en restore the right view.
The message used to alert the user *can* be improved, but understanding you are doing change in highest level its acceptable.
IMHO this must -> Wishlist

Regards,