PKG_CONFIG_LIBDIR needs to be set by xdeb

Bug #623478 reported by Nicolas Dechesne
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
xdeb (Ubuntu)
Fix Released
High
Wookey

Bug Description

Binary package hint: xdeb

This bug is related to the following email discussion: http://lists.linaro.org/pipermail/linaro-dev/2010-August/000494.html

When invoking debuild, xdeb should make sure that PKG_CONFIG_LIBDIR is set properly to /usr/arm-linux-gnueabi/lib/pkgconfig:
/usr/arm-linux-gnueabi/share/pkgconfig, otherwise pkg-config may not be able to find the proper pkg config data.

Tags: patch

Related branches

Loïc Minier (lool)
Changed in xdeb (Ubuntu):
status: New → Triaged
assignee: nobody → Wookey (wookey)
importance: Undecided → High
Revision history for this message
Loïc Minier (lool) wrote :

So as a workaround, we should add this for now:
    buildpackage.append('-ePKG_CONFIG_LIBDIR=/usr/%s/lib/pkgconfig' % deb_host_gnu_type)

IF there is no $triplet-pkg-config in the path (which there isn't right now).

Revision history for this message
Loïc Minier (lool) wrote :

Probably /usr/share/pkgconfig should be added as well, not /usr/$triplet/share/pkgconfig

Revision history for this message
Wookey (wookey) wrote : Re: [Bug 623478] Re: PKG_CONFIG_LIBDIR needs to be set by xdeb

+++ Loïc Minier [2010-08-24 17:16 -0000]:
> Probably /usr/share/pkgconfig should be added as well, not
> /usr/$triplet/share/pkgconfig

I think you are right that /usr/share/pkgconfig is a 'better' place,
but dpkg-cross currently puts arch-indep pkgconfig files in
/usr/$triplet/share/pkgconfig

So I guess it depends if the file is being supplied by the native
package or a -cross package. I'm not sure which is currently the case
with xdeb. I'll check.

Wookey
--
Principal hats: Linaro, Emdebian, Wookware, Balloonboard, ARM
http://wookware.org/

Revision history for this message
Wookey (wookey) wrote :

Here is a patch that adds this functionality/fixes the bug.

I don't have a good test-case to know if it really has the desired affect.

Revision history for this message
Wookey (wookey) wrote :
Revision history for this message
Loïc Minier (lool) wrote :

Thanks for working on this

Try building libxt (didn't try it out myself), it seems to call pkg-config for e.g. x11.pc

Your patch comments out GTEST_INCLUDEDIR and GTEST_LIBDIR.

You don't need string, you can 'foo:bar:baz'.split(os.pathsep). You could just provide a function to search an *executable* in the PATH rather than any file and passing the PATH to the function.

Do we really want /usr/%s/share/pkgconfig? It seems the right thing is /usr/share/pkgconfig? I believe you definitely want to list /usr/share/pkgconfig.

Could you send your next patch as a merge proposal?

Thanks!

Revision history for this message
Loïc Minier (lool) wrote :

Ah one more thing: your changelog entry should mention "LP: #1234" rather than "close: 1234" (closes is for Debian bugs).

tags: added: patch
Revision history for this message
Wookey (wookey) wrote :

in version 0.6.1

Changed in xdeb (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.