FEEDBACK-2 without option contains 12 bits of SN, not 8 bits

[Didier Barvaux]

According to section 5.7.6.1 entitled "Feedback formats for ROHC RTP" in RFC 3095, the FEEDBACK-2 packet format contains 12 bits of SN if no additional option is appended. According to section 5.7.6.6 entitled "The SN option" in RFC 3095, the FEEDBACK-2 packet may contain up to 20 bits of SN if a "SN option" is appended. However current code checks for SN values greater or equal than 255 (ie. 8 bits) to decide wether to append an SN option or not. This is not correct.

Many thanks to Ahmed Fathy that reported the problem in Question #120866.

[Didier Barvaux (didier-barvaux)]

Version 1.2.2 is affected.

[Didier Barvaux (didier-barvaux)]

Version 1.3.1 is affected.

[Didier Barvaux (didier-barvaux)]

Main branch is affected.

[Didier Barvaux (didier-barvaux)]

Fixed in trunk. See http://bazaar.launchpad.net/~didier-barvaux/rohc/main/revision/217

[Didier Barvaux (didier-barvaux)]

The bug will not be fixed in the 1.3.x branch since the fix would change the output of the library. The README file was updated to mention the existing bug. See http://bazaar.launchpad.net/~didier-barvaux/rohc/1.3.x/revision/153

[Didier Barvaux (didier-barvaux)]

The bug will not be fixed in the 1.2.x branch since the fix would change the output of the library. The README file was updated to mention the existing bug. See http://bazaar.launchpad.net/~didier-barvaux/rohc/1.2.x/revision/124