hr_timesheet : on_change_user_id does not pass proper uid!

[Raphaël Valyi - http://www.akretion.com]

Hello,

on v6 trunk at least and very likely on 5.0 too (can see that on older revision in like v5.0.12 at least), in the hr_timesheet module:
if you enter some hr.analytic.timesheet items in the editable list interface, if you change the user_id of a line, then the effect will be to use the id of the connected user, not the user you selected.
Indeed, the on_change_user_id method was implementation is totally wrong and doesn't even try to use the user_id (guys you never tried that code, even once, right?)

Here is an attached patch that fixes it (it doesn't claim that the overall resulting code will be clean and consistent but at least makes it work, BTW, names of function do not enforce PEP naming conventions in that file (Java camel case style instead)).

Hope this help. I'm sad to see things that have obviously never been tested presented as ""quality"" addons.

[Raphaël Valyi - http://www.akretion.com (rvalyi)]

Guys, I re-attached a new patch as the previous had a type (= symbol after return). This one works.

[Jay Vora (Serpent Consulting Services) (jayvora)]

Hello Raphael,

Thank you for your kind attention on this issue.

It has been fixed on trunk by revision 4786 <email address hidden>
and
on stable by revision 2824 <email address hidden> authored to you.