View access accessible when view is in a collection

Bug #620258 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Richard Mansfield

Bug Description

When a view is in a collection, its "Edit Access" page is still accessible and the access rights can be changed. When I went into the collection access rights, the new user had been added as well though I did not get a message on the view access page telling me that I update the collection access at the same time.

When I go to the view access page of another view in the same collection, I still have the old access rights in there.

As collection access rights overwrite view access rights, I would disable the "Edit View Access" link on a view that sits in a collection. The user cannot get to it from the view overview page - why should he get to it on the actual view? That would make it easier to edit the access rights for a collection really only on the collection page.

Revision history for this message
Stacey Walker (stacey) wrote :

Hi Kristina,

Are you talking about the link to the access page from the view itself?

I just discovered that by clicking on the visible 'Edit Access' in the top right of the view takes me back to the current views access page without realising that it is part of a collection.

I am wondering if we might want to:

a) change 'Edit Access' to go to the collections access page when the view is part of a collection and,
b) add an 'Edit Collection' link up there - so that a user can be looking at their new collections display and decide that "hang on that view doesn't quite belong in this collection now that I think about it ... " or "hmm, I want to change that navigation order around a bit" and want easy access back to this

Obviously there might be other solutions but these seem the easiest. :)

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Hi Stacey,

> Are you talking about the link to the access page from the view itself?

Yes, exactly.

I'm fonder of option a) when it can be made clear that they will be looking at the collection access page and not the view access page. And that they'll be changing the access for the entire collection.

Revision history for this message
Stacey Walker (stacey) wrote :

What do you think of adding the 'Edit Collection' link as well? I'd imagine this just linking to the collection/views.php page for managing viewlists.

Revision history for this message
Richard Mansfield (richard-mansfield) wrote :

Stacey,

It actually used to realise the view was part of a collection, but you broke that behaviour with 528d83b5 (grr!). I've just replaced the lines that did this (see db0750c3), but I guess you might want to try to remember if you had some other good reason for removing them earlier.

Changed in mahara:
status: New → Fix Committed
importance: Undecided → High
assignee: nobody → Richard Mansfield (richard-mansfield)
milestone: none → 1.3.0
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.