cat urlname warning when creating new blog

Bug #617928 reported by EdB
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Quam Plures
Fix Released
Low
EdB

Bug Description

http://forums.quamplures.net/viewtopic.php?p=848#p848

The problem is that when you create a blog it has to create a category and a unique cat_urlname, so it does, but it always gives an error-type message saying it created the new url_catname. So really the problem is that we say "Warning" when routine normal stuff happens. I'll commit a branch that solves this problem in a little while. Basically during cat creation for a new blog it goes and fetches the next available iteration of 'main-NN' then sets that, so no message is provided during db_commit().

Related branches

Revision history for this message
Tilman Blumenbach (tblue) wrote :

Well, technically the error message is correct: The url title got changed from "main" to "main-NN", but I see why that could be inconvenient for the user. Perhaps pre-filling the input field with the next available "main-NN" would be a better solution?

Revision history for this message
Tilman Blumenbach (tblue) wrote :

Also, I *think* your solution will suppress the error message completely, even if it would be valid (e. g. when the user entered some custom url name which then had to be changed).

Revision history for this message
EdB (edb) wrote :

Test it. I did, it doesn't.

Revision history for this message
EdB (edb) wrote :

Anyway "pre-filling" is what I did except there is no visible field for the user to even try to pre-fill something. Upon blog creation it makes a category named "Uncategorized" (which is a kinda funny name for a category eh?) then tries to set it's urlname to 'main' which of course only works once, so it throws an error after the first. The solution exists between setting the name and the urlname, so when it checks the urlname it finds an acceptable value.

But seriously: testing beats looking.

Revision history for this message
Tilman Blumenbach (tblue) wrote :

> there is no visible field for the user to even try to pre-fill something.
That's my fault, sorry. I only saw there's a form and thought it had a category name input. Stupid me.

> But seriously: testing beats looking.
Yep. Works flawlessly, will merge ASAP.

Changed in quam-plures:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.